Skip to content

Clarify WaitHandle.WaitAny/WaitAll behavior on STA threads #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2020
Merged

Clarify WaitHandle.WaitAny/WaitAll behavior on STA threads #3767

merged 2 commits into from
Jan 24, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 13, 2020

  • Update the documentation to capture maximum handle limits for STA threads (it is 63 vs. 64 for non-STA threads)
  • Change references STAThreadAttribute to a more general STA state. STAThreadAttribute is just one of the several ways to create thread in STA state.
  • Delete references to Windows 95 and Windows Millennium

Related to dotnet/runtime#1646

@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 13, 2020
@jkotas jkotas mentioned this pull request Jan 13, 2020
Merged
@jkotas
Copy link
Member Author

jkotas commented Jan 13, 2020

cc @stephentoub

mairaw
mairaw approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jkotas! LGTM

@mairaw mairaw merged commit 52429b4 into dotnet:master Jan 24, 2020
@jkotas jkotas deleted the waithandle-sta branch February 12, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@mairaw mairaw mairaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotas @stephentoub @mairaw @dotnet-bot