Skip to content

Update Environment.xml #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Update Environment.xml #3793

merged 1 commit into from
Jan 23, 2020

Conversation

birken25
Copy link
Contributor

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 22, 2020
@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jan 23, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 23, 2020

@carlossanlop can you help find the area owner?

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw I don't think this area has a specific owner, but the code is pretty straightforward:

https://github.com/dotnet/runtime/blob/2c6ec170197f42ce5ce21ceca27e89af6f1e6030/src/libraries/System.Private.CoreLib/src/System/Environment.Win32.cs#L118-L168

The UserName property calls the internal method GetUserName, which in turn does a P/Invoke to the Windows method GetUserNameExW, which has a very similar description in the official documentation, particularly regarding the current thread's user:

https://docs.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getusernameexw

Retrieves the name of the user or other security principal associated with the calling thread. You can specify the format of the returned name.

@mairaw mairaw merged commit 72a6f44 into dotnet:master Jan 23, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 23, 2020

Sounds good @carlossanlop! Thank you @birken25. Your contribution will show up live within a day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants