Skip to content

inline code invalid URIs #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

inline code invalid URIs #3800

merged 1 commit into from
Jan 24, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jan 23, 2020

So they're not rendered as links anymore

@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 23, 2020
@mairaw mairaw self-assigned this Jan 23, 2020
@mairaw mairaw requested a review from gewarren January 24, 2020 02:20
@mairaw
Copy link
Contributor Author

mairaw commented Jan 24, 2020

Example review URL: https://review.docs.microsoft.com/en-us/dotnet/api/System.IdentityModel.Protocols.WSTrust.KeyTypes.Asymmetric?branch=pr-en-us-3800&view=netframework-4.8

gewarren
gewarren approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit eba2673 into dotnet:master Jan 24, 2020
@mairaw mairaw deleted the brokenlinksops branch January 24, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees

@mairaw mairaw

Labels
None yet
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @gewarren @dotnet-bot