-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add runtime area owners for automatic PR review ownership #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mairaw I think you can merge. Btw I wonder whether there has been discussion about commit rights - I assume that is part of the discussion with @jeffhandley to restart when he is back. |
We've been adding devs to the write team @danmosemsft and all of these mentioned in the codeowners file will probably need write permissions in order to be properly tagged as a reviewer. |
Seems like a special team gives us flexibility. We might choose to give write rights to the conceptual docs also? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding all the right folks here @carlossanlop This will be a huge help.
I noticed two spots where a later rule would override one of the earlier rules. Once those are switched, I'll .
@danmosemsft @mairaw @carlossanlop I don't have strong opinions on whether to add these folks to the "docs-write" team, or create a dedicate "api-docs-write" team. There is simplicity in one team, and all the people listed are trusted contributors. Separate teams would provide increased granularity. I'll propose the simple solution of adding these folks to the docs-write team. Upvote of downvote this recommendation, and I'll make the necessary changes by Monday. (Downvote would mean to create a new "api-docs-write" team.) |
@BillWagner can you please take a look again? |
This is great now @carlossanlop |
We should give RW access to entire dotnet/runtime team - dotnet-corefx would do I guess (unless @terrajobst plans to change the groups), otherwise we have to maintain membership in 2 places, which usually doesn't scale long-term ... |
@BillWagner would this make your job of giving us permissions a bit easier? |
Done. dotnet/dotnet-corefx has been given write access here. |
Second attempt now that the area ownership shuffle has been officially published: https://github.com/dotnet/runtime/blob/master/docs/area-owners.md
This change is part of the ongoing effort to share PR review responsibility between the Docs team and the Libraries team, and will help speed up the documentation process and ensure the right people (area owners) get notified when their PR review and approval is required.