Skip to content

Conversation

carlossanlop
Copy link
Contributor

Second attempt now that the area ownership shuffle has been officially published: https://github.com/dotnet/runtime/blob/master/docs/area-owners.md

This change is part of the ongoing effort to share PR review responsibility between the Docs team and the Libraries team, and will help speed up the documentation process and ensure the right people (area owners) get notified when their PR review and approval is required.

@carlossanlop carlossanlop self-assigned this Feb 21, 2020
@dotnet-bot dotnet-bot added this to the February 2020 milestone Feb 21, 2020
@danmoseley
Copy link
Member

danmoseley commented Feb 21, 2020

@mairaw I think you can merge.

Btw I wonder whether there has been discussion about commit rights - I assume that is part of the discussion with @jeffhandley to restart when he is back.

@mairaw
Copy link
Contributor

mairaw commented Feb 21, 2020

We've been adding devs to the write team @danmosemsft and all of these mentioned in the codeowners file will probably need write permissions in order to be properly tagged as a reviewer.
@BillWagner I had been adding devs to the docs-write team but I was wondering if a separate team should be created that would only be used in this repo instead of broadly giving write permissions to all docs repos. Up to you!

@danmoseley
Copy link
Member

Seems like a special team gives us flexibility. We might choose to give write rights to the conceptual docs also?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding all the right folks here @carlossanlop This will be a huge help.

I noticed two spots where a later rule would override one of the earlier rules. Once those are switched, I'll :shipit:.

@BillWagner
Copy link
Member

BillWagner commented Feb 21, 2020

@danmosemsft @mairaw @carlossanlop

I don't have strong opinions on whether to add these folks to the "docs-write" team, or create a dedicate "api-docs-write" team. There is simplicity in one team, and all the people listed are trusted contributors. Separate teams would provide increased granularity.

I'll propose the simple solution of adding these folks to the docs-write team. Upvote of downvote this recommendation, and I'll make the necessary changes by Monday. (Downvote would mean to create a new "api-docs-write" team.)

@carlossanlop
Copy link
Contributor Author

@BillWagner can you please take a look again?

@BillWagner
Copy link
Member

This is great now @carlossanlop
You can :shipit: when ready.

@karelz
Copy link
Member

karelz commented Feb 21, 2020

We should give RW access to entire dotnet/runtime team - dotnet-corefx would do I guess (unless @terrajobst plans to change the groups), otherwise we have to maintain membership in 2 places, which usually doesn't scale long-term ...

@carlossanlop
Copy link
Contributor Author

We should give RW access to entire dotnet/runtime team - dotnet-corefx would do I guess (unless @terrajobst Immo Landwerth FTE plans to change the groups)

@BillWagner would this make your job of giving us permissions a bit easier?

@BillWagner
Copy link
Member

@carlossanlop @karelz

We should give RW access to entire dotnet/runtime team - dotnet-corefx would do I guess (unless @terrajobst Immo Landwerth FTE plans to change the groups)

Done. dotnet/dotnet-corefx has been given write access here.

@carlossanlop carlossanlop merged commit 56c319d into dotnet:master Feb 21, 2020
@carlossanlop carlossanlop deleted the AreaOwners branch February 21, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants