Skip to content

System.Threading.Tasks.Dataflow automatic port of comments #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

System.Threading.Tasks.Dataflow automatic port of comments #3939

merged 2 commits into from
Feb 26, 2020

Conversation

carlossanlop
Copy link
Contributor

Fixes #3923

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews Release: .NET Core 1.x labels Feb 26, 2020
@carlossanlop carlossanlop added this to the February 2020 milestone Feb 26, 2020
@carlossanlop carlossanlop self-assigned this Feb 26, 2020
@carlossanlop carlossanlop requested a review from a team February 26, 2020 07:14
stephentoub
stephentoub approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is all automated porting, LGTM. Thanks.

BillWagner
BillWagner approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @carlossanlop

I'll :shipit: now

@BillWagner BillWagner merged commit 18345c6 into dotnet:master Feb 26, 2020
@carlossanlop carlossanlop deleted the TasksDataflow branch February 26, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@stephentoub stephentoub stephentoub approved these changes

@tarekgh tarekgh Awaiting requested review from tarekgh

Assignees

@carlossanlop carlossanlop

Labels
new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.

System.Threading.Tasks 1.x undocumented APIs
3 participants
@carlossanlop @BillWagner @stephentoub