Skip to content

UnixDomainSocketEndPoint constructor exceptions #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

UnixDomainSocketEndPoint constructor exceptions #3990

merged 1 commit into from
Mar 18, 2020

Conversation

carlossanlop
Copy link
Contributor

While investigating this issue, and trying to learn about the UnixDomainSocketEndPoint type, I realized the exceptions are not documented in the constructor, so I added them (source).

@carlossanlop carlossanlop requested a review from a team as a code owner March 13, 2020 20:10
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 13, 2020
@carlossanlop carlossanlop requested review from jozkee and a team March 13, 2020 20:10
@carlossanlop carlossanlop self-assigned this Mar 13, 2020
@carlossanlop carlossanlop added doc-enhancement Improve the current content new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged labels Mar 13, 2020
@carlossanlop carlossanlop force-pushed the UnixDomainSocketEndPoint branch from 1f0adec to b0823c1 Compare March 17, 2020 19:31
@carlossanlop
Copy link
Contributor Author

Can I please get a review, members of @dotnet/ncl?

@carlossanlop carlossanlop merged commit b3194dc into master Mar 18, 2020
@carlossanlop carlossanlop deleted the UnixDomainSocketEndPoint branch March 18, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@karelz karelz karelz approved these changes

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@carlossanlop carlossanlop

Labels
doc-enhancement Improve the current content new-content Indicates PRs that contain new articles waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @halter73 @karelz @dotnet-bot