-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Key sizes can only be certain lengths #3992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The wording could be interpreted as "any value between 128 and 256 bits is valid" leading to confision. Specifying exact values will hopefully provide more clarity and eliminate confusion. See https://github.com/microsoft/referencesource/blob/master/System.Core/System/Security/Cryptography/AesCryptoServiceProvider.cs#L323 for implementation details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth checking with AesCng and Aes (the base class) to make sure that they're all equally clear.
added same valid `KeySize` clarification to related `AesCng` class
Documentation for
|
code review changes
was there anything else I could do to move this PR along? |
@dotnet/docs This is ready for final review |
The wording could be interpreted as "any value between 128 and 256 bits is valid" leading to confision.
Specifying exact values will hopefully provide more clarity and eliminate confusion.
See https://github.com/microsoft/referencesource/blob/master/System.Core/System/Security/Cryptography/AesCryptoServiceProvider.cs#L323 for implementation details.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)