Skip to content

Add files that didn't copy because of script err #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2020
Merged

Add files that didn't copy because of script err #3999

merged 4 commits into from
Mar 18, 2020

Conversation

Thraka
Copy link
Contributor

@Thraka Thraka commented Mar 17, 2020

Summary

The script had a problem with

  1. If the destination directory existed but didn't have any files.
  2. If the directory used characters that needed to be escaped.

@Thraka Thraka requested a review from BillWagner March 17, 2020 22:03
@Thraka Thraka requested a review from a team as a code owner March 17, 2020 22:03
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 17, 2020
tdykstra
tdykstra approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thraka Thraka closed this Mar 17, 2020
@Thraka Thraka reopened this Mar 17, 2020
@Thraka Thraka merged commit e7251d9 into master Mar 18, 2020
@Thraka Thraka deleted the adegeo-fix-missing branch March 18, 2020 03:12
@BillWagner BillWagner mentioned this pull request Mar 18, 2020
Closed
@Thraka Thraka self-assigned this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

@Thraka Thraka

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@Thraka @tdykstra @dotnet-bot