Skip to content

Add remarks regarding the initial content of span in string.Create #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2020
Merged

Add remarks regarding the initial content of span in string.Create #4028

merged 3 commits into from
Mar 23, 2020

Conversation

Gnbrkm41
Copy link
Contributor

@Gnbrkm41 Gnbrkm41 requested a review from a team as a code owner March 22, 2020 07:29
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 22, 2020
stephentoub
stephentoub reviewed Mar 22, 2020
View reviewed changes
@Gnbrkm41 @stephentoub
Apply suggestions
faff6d8 
Co-Authored-By: stephentoub <[email protected]>
bartonjs
bartonjs reviewed Mar 22, 2020
View reviewed changes
@Gnbrkm41 @bartonjs
Apply suggestions
8be3353 
Co-Authored-By: Jeremy Barton <[email protected]>
BillWagner
BillWagner approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Gnbrkm41

Thanks for the suggestions @stephentoub and @bartonjs

I'll :shipit: now.

@BillWagner BillWagner merged commit 8df7c4a into dotnet:master Mar 23, 2020
@Gnbrkm41 Gnbrkm41 deleted the stringCreate branch March 25, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@bartonjs bartonjs bartonjs left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.

Consider documenting the initial contents of the Span<char> passed into SpanAction of string.Create method
5 participants
@Gnbrkm41 @BillWagner @stephentoub @bartonjs @dotnet-bot