Skip to content

Update installcontext_installcontext.cs #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Mar 30, 2020
Merged

Update installcontext_installcontext.cs #4047

merged 1 commit into from Mar 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2020

Summary

I changed the source to call base class's Install, Uninstall, Rollback and Commit methods first in derived methods.

@ghost ghost self-requested a review as a code owner March 29, 2020 15:49
@dotnet-bot dotnet-bot added this to the April 2020 milestone Mar 29, 2020
BillWagner
BillWagner approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @Asugakoisi

I've reviewed the code, and I'll :shipit: now.

Thanks again for contributing to docs.

@BillWagner BillWagner merged commit 8bb37c3 into dotnet:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@BillWagner @dotnet-bot