Skip to content

Add clarification to SuppressMessageAttribute #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Mar 31, 2020

I see // SuppressMessage attributes do not apply to compiler diagnostics. in Roslyn, but I think it is useful to make that clear in the documentation.

Tagging @BillWagner

I see `// SuppressMessage attributes do not apply to compiler diagnostics.` in Roslyn, but I think it is useful to make that clear in the documentation.

Tagging @BillWagner
@jcouv
Copy link
Member Author

jcouv commented Apr 8, 2020

@BillWagner @mairaw Could you help with review or routing this? Thanks

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @jcouv

I'll :shipit: now.

@BillWagner BillWagner merged commit 5e0c024 into master Apr 11, 2020
@BillWagner BillWagner deleted the dev/jcouv/suppress-message branch April 11, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants