Redundant variable usage #4075
Merged
Redundant variable usage #4075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I propose remove lowest variable, because it redundant and we have the same value in result of the loop. Change output with string interpolation. Sorry, not sure about formatting. For sure both changes are not critical.
|
|
BillWagner
added
the
✨ 1st-time dotnet-api-docs contributor!
BillWagner
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Thanks for making this code simpler and easier to read @bdrum We appreciate it.
I've reviewed the changes, and I'll 
now.
Thanks again for contributing to docs! 🎆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thanks for the nice docs!
I've studying the docs and in this section from my side the code could be better.
I propose remove lowest variable, because it redundant and we have the same value in result of the loop.
Also change the output with string interpolation.
Sorry, not sure about formatting.
For sure both changes are not critical.