Skip to content

Differentiate summary for BuildServiceProvider #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2020
Merged

Differentiate summary for BuildServiceProvider #4088

merged 2 commits into from
Apr 9, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 8, 2020 •
edited
Loading

Addresses https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1091296 feedback - preview link.

Also fixes code block in ServiceProviderOptions - preview link.

@gewarren gewarren requested a review from a team as a code owner April 8, 2020 21:08
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 8, 2020
BillWagner
BillWagner approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren
Copy link
Contributor Author

gewarren commented Apr 9, 2020

Thanks Bill!

@gewarren gewarren merged commit 8907e97 into dotnet:master Apr 9, 2020
@gewarren gewarren deleted the buildserviceprovider branch April 9, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
area-Extensions-DependencyInjection
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@gewarren @BillWagner @maryamariyan @dotnet-bot