Skip to content

.NET Interactive: Enable_try_dotnet_to_batch6a #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2020
Merged

.NET Interactive: Enable_try_dotnet_to_batch6a #4167

merged 2 commits into from
Apr 28, 2020

Conversation

@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 27, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented Apr 27, 2020

FYI @mairaw :)

@mairaw mairaw self-requested a review April 27, 2020 22:05
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Apr 27, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-mepa. Changes look good but changes for the last two URLs don't seem to be in (or 100% done). Can you double check? I'm also fine merging this change and leaving those two URLs for the next batch. Let me know.

@v-mepa
Copy link
Contributor Author

v-mepa commented Apr 27, 2020

Let me check and update.

@v-mepa
Copy link
Contributor Author

v-mepa commented Apr 27, 2020

I updated the code for all the samples for last 2 URL's. Let me know if this looks good.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks!

@mairaw mairaw merged commit d38e752 into dotnet:master Apr 28, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_6a branch April 29, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants