Skip to content

Show only language selected #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Show only language selected #4172

merged 1 commit into from
Apr 29, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 28, 2020

URL: https://docs.microsoft.com/en-us/dotnet/api/system.object.tostring

If C# is selected, there's no need for VB to be displayed and vice versa

image

@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 28, 2020
@mairaw mairaw requested a review from a team April 29, 2020 17:54
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all API docs have a language picker by default?

@carlossanlop
Copy link
Contributor

@mairaw will this ensure that the user only sees the code snippet for the selected language in the top dropdown?
image

@mairaw
Copy link
Contributor Author

mairaw commented Apr 29, 2020

Yes @gewarren and yes @carlossanlop (unless the snippet for the selected language doesn't exist, then a fallback language is displayed)

@mairaw mairaw merged commit fe1663c into master Apr 29, 2020
@mairaw mairaw deleted the mairaw-patch-1 branch April 29, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants