Skip to content

Fix comments on CancellationTokenRegistration.Token #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions xml/System.Threading/CancellationTokenRegistration.xml
Original file line number Diff line number Diff line change
Expand Up @@ -450,12 +450,17 @@ The returned <xref:System.Threading.Tasks.ValueTask> completes once the associat
<ReturnType>System.Threading.CancellationToken</ReturnType>
</ReturnValue>
<Docs>
<summary>Gets the <see cref="T:System.Threading.CancellationToken" /> with which this registration is associated. If the
registration isn't associated with a token (such as after the registration has been disposed),
this will return a default token.</summary>
<summary>Gets the <see cref="T:System.Threading.CancellationToken" /> with which this registration is associated.</summary>
<value>The cancellation token with which this registration is associated, or a default token if the
registration isn't associated with a token (such as after the registration has been disposed).</value>
<remarks>To be added.</remarks>
registration isn't associated with a token.</value>
<remarks>
<format type="text/markdown"><![CDATA[
If the <xref:System.Threading.CancellationTokenRegistration> was created by registering with a <xref:System.Threading.CancellationToken> that already
had cancellation requested, the registration may not be associated with the token, in which case this property may return a default token.
]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Unregister">
Expand Down