Skip to content

Update Marshal.PtrToStringAnsi - UTF-8 on Unix #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Update Marshal.PtrToStringAnsi - UTF-8 on Unix #4238

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e219ff
Update Marshal.PtrToStringAnsi - UTF-8 on Unix
nxtn May 14, 2020
dfee961
Change mentions of Unicode to UTF-16
nxtn Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions xml/System.Runtime.InteropServices/Marshal.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6168,7 +6168,7 @@ There is a difference in the behavior of the `GetLastWin32Error` method on .NET
<AssemblyVersion>4.2.0.0</AssemblyVersion>
</AssemblyInfo>
<Docs>
<summary>Allocates a managed <see cref="T:System.String" /> and copies all or part of an unmanaged ANSI string into it.</summary>
<summary>Allocates a managed <see cref="T:System.String" /> and copies all or part of an unmanaged ANSI (on Windows) or UTF-8 (on Unix) string into it.</summary>
</Docs>
</MemberGroup>
<Member MemberName="PtrToStringAnsi">
Expand Down Expand Up @@ -6216,8 +6216,8 @@ There is a difference in the behavior of the `GetLastWin32Error` method on .NET
</Parameters>
<Docs>
<param name="ptr">The address of the first character of the unmanaged string.</param>
<summary>Copies all characters up to the first null character from an unmanaged ANSI string to a managed <see cref="T:System.String" />, and widens each ANSI character to Unicode.</summary>
<returns>A managed string that holds a copy of the unmanaged ANSI string. If <paramref name="ptr" /> is <see langword="null" />, the method returns a null string.</returns>
<summary>Copies all characters up to the first null character from an unmanaged ANSI or UTF-8 string to a managed <see cref="T:System.String" />, and widens each character to Unicode.</summary>
<returns>A managed string that holds a copy of the unmanaged string. If <paramref name="ptr" /> is <see langword="null" />, the method returns a null string.</returns>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down Expand Up @@ -6284,8 +6284,8 @@ There is a difference in the behavior of the `GetLastWin32Error` method on .NET
<Docs>
<param name="ptr">The address of the first character of the unmanaged string.</param>
<param name="len">The byte count of the input string to copy.</param>
<summary>Allocates a managed <see cref="T:System.String" />, copies a specified number of characters from an unmanaged ANSI string into it, and widens each ANSI character to Unicode.</summary>
<returns>A managed string that holds a copy of the native ANSI string if the value of the <paramref name="ptr" /> parameter is not <see langword="null" />; otherwise, this method returns <see langword="null" />.</returns>
<summary>Allocates a managed <see cref="T:System.String" />, copies a specified number of characters from an unmanaged ANSI or UTF-8 string into it, and widens each character to Unicode.</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the mention of Unicode to UTF-16? (Both mentions)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes full sense. We have a lot of "Unicode" to change in this area.

<returns>A managed string that holds a copy of the native string if the value of the <paramref name="ptr" /> parameter is not <see langword="null" />; otherwise, this method returns <see langword="null" />.</returns>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down