Skip to content

Retire filemap link to dotnet/docs #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2020
Merged

Retire filemap link to dotnet/docs #4248

merged 2 commits into from
May 22, 2020

Conversation

live1206
Copy link
Contributor

Summary

Offline discussed with @BillWagner , we are going to retire "filemap_share_depots", use absolute links to files in dotnet/docs

Fixes #Issue_Number (if available)

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 16, 2020
@live1206
Copy link
Contributor Author

cc @herohua @cillroy

BillWagner
BillWagner approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LGTM. I'll :shipit:

For review:

  • Checked config.
  • Spot-checked several of the files.
  • Spot-checked review site.
  • Checked build report.

@BillWagner BillWagner merged commit 44af8fa into dotnet:master May 22, 2020
@mingwli mingwli mentioned this pull request May 26, 2020
Merged
@TianqiZhang TianqiZhang mentioned this pull request May 27, 2020
Merged
@live1206 live1206 mentioned this pull request May 28, 2020
Merged
@mairaw mairaw mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@live1206 @BillWagner @dotnet-bot