Skip to content

Conversation

v-mepa
Copy link
Contributor

@v-mepa v-mepa commented May 18, 2020

Enable_try_dotnet_to_batch_8c

URL Comments
https://docs.microsoft.com/en-us/dotnet/api/system.char.tostring Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.iswhitespace Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.iscontrol Only enable for first example. Second example might be culture or OS dependent?
https://docs.microsoft.com/en-us/dotnet/api/system.char.tolower Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.isletterordigit Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.issymbol Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.ispunctuation Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.converttoutf32 Duplicate samples for all overloads? Potentially move it to the MemberGroup

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 18, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented May 18, 2020

fyi @mairaw, let me know how this looks :)

@mairaw mairaw self-requested a review May 19, 2020 01:53
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label May 19, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but there are some examples that are still inside the members...

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great now. Thanks @v-mepa!

@mairaw mairaw merged commit feff92f into dotnet:master Jun 1, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_8c branch June 1, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants