Skip to content

Conversation

v-mepa
Copy link
Contributor

@v-mepa v-mepa commented May 19, 2020

Enable_try_dotnet_to_batch_8d

URL Comments
https://docs.microsoft.com/en-us/dotnet/api/system.char.getunicodecategory Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.isseparator  
https://docs.microsoft.com/en-us/dotnet/api/system.char.islower Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.ishighsurrogate Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.compareto Enable only for the second example. First sample is culture dependent.
https://docs.microsoft.com/en-us/dotnet/api/system.char.issurrogate Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.islowsurrogate Duplicate samples for all overloads? Potentially move it to the MemberGroup
https://docs.microsoft.com/en-us/dotnet/api/system.char.issurrogatepair Duplicate samples for all overloads? Potentially move it to the MemberGroup

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 19, 2020
@v-mepa
Copy link
Contributor Author

v-mepa commented May 19, 2020

fyi @mairaw , let me know how it looks.

@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label May 20, 2020
@mairaw mairaw self-requested a review May 20, 2020 01:15
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but some examples are still inside the specific overloads

## Examples
## Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to the MemberGroup element

## Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be moved to the MemberGroup element

## Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to the MemberGroup element

## Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to the MemberGroup element

## Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to the MemberGroup element

## Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to the MemberGroup element

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. Thanks @v-mepa!

@mairaw mairaw merged commit 30e2950 into dotnet:master Jun 1, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_8d branch June 1, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants