Skip to content

Fix defaultCredentialsHandleCacheSize docs #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

davidsh
Copy link
Contributor

@davidsh davidsh commented Jun 15, 2020

The documentation for the defaultCredentialsHandleCacheSize setting is incorrect.

The documentation for the `defaultCredentialsHandleCacheSize` setting is incorrect.
@davidsh davidsh self-assigned this Jun 15, 2020
@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 15, 2020
@davidsh davidsh requested review from gewarren and a team June 15, 2020 14:46
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidsh
Copy link
Contributor Author

davidsh commented Jun 15, 2020

@gewarren

I merged your suggested changes. But the preview build looks strange:
image

@davidsh
Copy link
Contributor Author

davidsh commented Jun 15, 2020

Looks like there was a typo in the suggested changes. I added a "." to the element.

@davidsh davidsh merged commit 84f04cc into dotnet:master Jun 15, 2020
@davidsh davidsh deleted the defaultCredentialsHandleCacheSize_fix branch June 15, 2020 23:30
@gewarren
Copy link
Contributor

Looks like there was a typo in the suggested changes. I added a "." to the element.

Oops, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants