Fix remarks for Insert overload which takes CacheDependency #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Remarks for the overload of `Insert` which takes a `CacheDependency` appears to have been copied and pasted from the overload which does not take that parameter and therefore stated that the object added to the cache would be inserted with "no file or cache dependencies", which of course is incorrect. This edit removes that text.
|
Ping @scottaddie |
scottaddie
approved these changes
Jul 22, 2020
|
Thank you for fixing this, @mikemccaughan |
|
Glad I could be of help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Remarks for the overload of
Insertwhich takes aCacheDependencyappears to have been copied and pasted from the overload which does not take that parameter and therefore stated that the object added to the cache would be inserted with "no file or cache dependencies", which is the purpose of the overload. This edit removes that text.