Skip to content

.NET Interactive: Enable_try_dotnet_to_batch_14a #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2020
Merged

.NET Interactive: Enable_try_dotnet_to_batch_14a #4487

merged 2 commits into from
Jul 9, 2020

Conversation

v-mepa
Copy link
Contributor

@v-mepa v-mepa commented Jul 8, 2020

Enable_try_dotnet_to_batch_14a

S No. URL Try .NET Status Comments
1 https://docs.microsoft.com/en-us/dotnet/api/system.collections.specialized.namevaluecollection Batch 14  
2 https://docs.microsoft.com/en-us/dotnet/api/system.indexoutofrangeexception Batch 14 Only samples 2, 7, 9 (I'm ignoring little boxes with no language indicated). Other samples throw exception or require arguments to be passed.
3 https://docs.microsoft.com/en-us/dotnet/api/system.argumentoutofrangeexception Batch 14 Only samples 1, 2, 6, 8, 13, 14. Others throw exception or are not runnable. Dependent on PR 4479.
4 https://docs.microsoft.com/en-us/dotnet/api/system.text.encoder Batch 14  
5 https://docs.microsoft.com/en-us/dotnet/api/system.type.isgenerictype Batch 14  
6 https://docs.microsoft.com/en-us/dotnet/api/system.linq.queryable.union Batch 14  
7 https://docs.microsoft.com/en-us/dotnet/api/system.text.utf8encoding.getpreamble Batch 14 Fix sample 2 output

fyi @mairaw , I was not sure for comment "fix sample output for 2" even after checking PR #4457. Let me know.

@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 8, 2020
@mairaw mairaw self-requested a review July 8, 2020 23:05
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Jul 8, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @v-mepa. I've missed one sample review when I was preparing this batch so left a suggestion that can be quickly applied.

[!code-csharp[System.Type.IsGenericType#2](~/samples/snippets/csharp/VS_Snippets_CLR_System/system.Type.IsGenericType/cs/remarks.cs#2)]
[!code-vb[System.Type.IsGenericType#2](~/samples/snippets/visualbasic/VS_Snippets_CLR_System/system.Type.IsGenericType/vb/remarks.vb#2)]
:::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR_System/system.Type.IsGenericType/cpp/remarks.cpp" id="Snippet2":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR_System/system.Type.IsGenericType/cs/remarks.cs" interactive="try-dotnet-method" id="Snippet2":::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR_System/system.Type.IsGenericType/cs/remarks.cs" interactive="try-dotnet-method" id="Snippet2":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR_System/system.Type.IsGenericType/cs/remarks.cs" id="Snippet2":::

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wont let me commit here so applied changes locally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a GitHub bug with very large files

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @v-mepa!

@mairaw mairaw merged commit fc57f7f into dotnet:master Jul 9, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_14a branch July 9, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants