Skip to content

Security update for JavaScriptTypeResolver and SimpleTypeResolver #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 24, 2020
Merged

Security update for JavaScriptTypeResolver and SimpleTypeResolver #4563

merged 7 commits into from
Jul 24, 2020

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Jul 22, 2020 •
edited
Loading

@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 22, 2020
@Rick-Anderson Rick-Anderson marked this pull request as draft July 22, 2020 23:53
GrabYourPitchforks
GrabYourPitchforks approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal preview site looks good! Thanks for giving it a bit of your magic. :)

glihm
glihm approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@glihm
Copy link
Contributor

glihm commented Jul 24, 2020

@Rick-Anderson hello,
As an external, do we have a possibility to see a preview of changes?

Thanks for the great work!

@gewarren
Copy link
Contributor

@Rick-Anderson hello,
As an external, do we have a possibility to see a preview of changes?

Unfortunately, no :( We have been pushing to make the preview site available to external contributors, but so far, it's not.

@Rick-Anderson Rick-Anderson marked this pull request as ready for review July 24, 2020 17:34
gewarren
gewarren approved these changes Jul 24, 2020
View reviewed changes
@Rick-Anderson Rick-Anderson merged commit 2a0a389 into master Jul 24, 2020
@Rick-Anderson Rick-Anderson deleted the JavaScriptTypeResolver-insecure/ra branch July 24, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@gewarren gewarren gewarren approved these changes

+1 more reviewer

@glihm glihm glihm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

Update insecure samples for JavaScriptTypeResolver and SimpleTypeResolver
5 participants
@Rick-Anderson @glihm @gewarren @GrabYourPitchforks @dotnet-bot