UTF-7 updates for .NET 5 #4586
Merged
UTF-7 updates for .NET 5 #4586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
commented
Jul 28, 2020
|
|
||
| - On .NET Core, if no encoding provider has been registered or if no registered encoding provider handles a `codepage` value of 0, it returns the <xref:System.Text.UTF8Encoding>. | ||
|
|
||
| > [!NOTE] | ||
| > Some unsupported code pages cause an <xref:System.ArgumentException> to be thrown, whereas others cause a <xref:System.NotSupportedException>. Therefore, your code must catch all exceptions indicated in the Exceptions section. | ||
| > - Some unsupported code pages cause an <xref:System.ArgumentException> to be thrown, whereas others cause a <xref:System.NotSupportedException>. Therefore, your code must catch all exceptions indicated in the Exceptions section. | ||
| > - In .NET 5.0 and later versions, the code page identifier `65000`, which represents UTF-7, is not supported. |
gewarren
commented
Jul 28, 2020
|
|
||
| > [!NOTE] | ||
| > The ANSI code pages can be different on different computers, or can be changed for a single computer, leading to data corruption. For the most consistent results, you should use Unicode, such as UTF-8 (code page 65001) or UTF-16, instead of a specific code page. | ||
| In .NET 5.0 and later versions, the code page name `utf-7` is not supported. |
gewarren
commented
Jul 28, 2020
| @@ -3754,29 +3718,28 @@ In the .NET Framework, the <xref:System.Text.Encoding.GetEncoding%2A> method rel | |||
| ## Remarks | |||
|
|
|||
| > [!NOTE] | |||
| > Some unsupported code pages cause the exception <xref:System.ArgumentException> to be thrown, whereas others cause <xref:System.NotSupportedException>. Therefore, your code must catch all exceptions indicated in the Exceptions section. | |||
| > - Some unsupported code pages cause the exception <xref:System.ArgumentException> to be thrown, whereas others cause <xref:System.NotSupportedException>. Therefore, your code must catch all exceptions indicated in the Exceptions section. | |||
| > - In .NET 5.0 and later versions, the code page identifier `65000`, which represents UTF-7, is not supported. | |||
gewarren
commented
Jul 28, 2020
| In addition to the encodings that are natively available on .NET Core or that are intrinsically supported on a specific platform version of the .NET Framework, the <xref:System.Text.Encoding.GetEncoding%2A> method returns any additional encodings that are made available by registering an <xref:System.Text.EncodingProvider> object. If the same encoding has been registered by multiple <xref:System.Text.EncodingProvider> objects, this method returns the last one registered. | ||
| In addition to the encodings that are natively available on .NET Core or that are intrinsically supported on a specific platform version of .NET Framework, the <xref:System.Text.Encoding.GetEncoding%2A> method returns any additional encodings that are made available by registering an <xref:System.Text.EncodingProvider> object. If the same encoding has been registered by multiple <xref:System.Text.EncodingProvider> objects, this method returns the last one registered. | ||
|
|
||
| In .NET 5.0 and later versions, the code page name `utf-7` is not supported. |
gewarren
commented
Jul 28, 2020
| |57009|x-iscii-ma|ISCII Malayalam|✓||| | ||
| |57010|x-iscii-gu|ISCII Gujarati|✓||| | ||
| |57011|x-iscii-pa|ISCII Punjabi|✓||| | ||
| |65000|utf-7|Unicode (UTF-7)|✓|✓|| |
There was a problem hiding this comment.
Added new column for .NET 5 and left it unchecked.
There was a problem hiding this comment.
I don't see the table reflected at https://review.docs.microsoft.com/en-us/dotnet/api/system.text.encoding?branch=master&view=net-5.0, but the XML looks fine.
There was a problem hiding this comment.
It looks like the branch reverted to master in your URL. It's here: https://review.docs.microsoft.com/en-us/dotnet/api/system.text.encoding?branch=pr-en-us-4586&view=net-5.0#list-of-encodings.
GrabYourPitchforks
approved these changes
Jul 28, 2020
BillWagner
approved these changes
Jul 29, 2020
when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore whitespace changes in the diff.
Example preview link (see Remarks section).