-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Modernize 3DES examples #8742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize 3DES examples #8742
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsRelated to dotnet/runtime#79924. This PR deletes some outdated and duplicate samples for 3DES, modernizes the C# version of the remaining sample and removes samples from the obsolete Also updates the remarks of
|
This comment was marked as outdated.
This comment was marked as outdated.
This was already fixed in #8384. Not sure why the updated samples aren't showing up on there; but that's the structure and style that I rewrote these samples to, and would prefer to not change any of the styling. |
@bartonjs I think your previous PR only addressed |
In that case.. the text updates and deleting all of the examples that pertain specifically to TripleDESCryptoServiceProvider are welcome; but changing the C# 3DES example is not (because then it doesn't match the VB or CPP-CLI samples, or the AES/RC2/etc samples). |
snippets/csharp/System.Security.Cryptography/TripleDES/Create/fileexample.cs
Outdated
Show resolved
Hide resolved
snippets/csharp/System.Security.Cryptography/TripleDES/Create/memoryexample.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3DES core C# samples should remain as-is, so they are consistent across languages and similar classes.
This comment was marked as outdated.
This comment was marked as outdated.
@bartonjs I think that having outdated C# examples is worse than being inconsistent. I would be fine with updating examples for other classes or for the other languages (where possible), but I really think the primary examples should demonstrate modern coding styles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just delete the C++ examples.
Related to dotnet/runtime#79924.
This PR deletes some outdated and duplicate samples for 3DES, modernizes the C# version of the remaining sample and removes samples from the obsolete
TripleDESCryptoServiceProvider
class.Also updates the remarks of
TripleDESCryptoServiceProvider
to link to theTripleDES.Create
method.