Skip to content

Fix for transpilation of k8s.Models.ResourceQuantity #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for transpilation of k8s.Models.ResourceQuantity #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e8166f
fix: Add special case for ResourceQuanitty transpilation fixes #958
ian-buse Oct 1, 2025
f882b30
Merge branch 'dotnet:main' into main
ian-buse Oct 1, 2025
adf3017
linting: Add missing space
ian-buse Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/KubeOps.Transpiler/Crds.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,9 @@ private static V1JSONSchemaProps MapObjectType(this MetadataLoadContext context,
{
switch (type.FullName)
{
case "k8s.Models.ResourceQuantity":
// Quantities are serialized as strings in CRDs (e.g., "500m", "2Gi")
return new V1JSONSchemaProps { Type = String };
case "k8s.Models.V1ObjectMeta":
return new V1JSONSchemaProps { Type = Object };
case "k8s.Models.IntstrIntOrString":
Expand Down
7 changes: 7 additions & 0 deletions test/KubeOps.Transpiler.Test/Crds.Mlc.Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public partial class CrdsMlcTest(MlcProvider provider) : TranspilerTestBase(prov
[InlineData(typeof(DateTimeOffsetTestEntity), "string", "date-time", null)]
[InlineData(typeof(NullableDateTimeOffsetTestEntity), "string", "date-time", true)]
[InlineData(typeof(V1ObjectMetaTestEntity), "object", null, null)]
[InlineData(typeof(ResourceQuantityTestEntity), "string", null, null)]
[InlineData(typeof(StringArrayEntity), "array", null, null)]
[InlineData(typeof(NullableStringArrayEntity), "array", null, true)]
[InlineData(typeof(EnumerableIntEntity), "array", null, null)]
Expand Down Expand Up @@ -631,6 +632,12 @@ private class V1ObjectMetaTestEntity : CustomKubernetesEntity
public V1ObjectMeta Property { get; set; } = null!;
}

[KubernetesEntity(Group = "testing.dev", ApiVersion = "v1", Kind = "TestEntity")]
private class ResourceQuantityTestEntity : CustomKubernetesEntity
{
public ResourceQuantity Property { get; set; } = null!;
}

[KubernetesEntity(Group = "testing.dev", ApiVersion = "v1", Kind = "TestEntity")]
private class StringArrayEntity : CustomKubernetesEntity
{
Expand Down