[release/9.0] Avoid using ^ and ~ when invalid because of value converters

[roji]

Fixes #35093
Backports #35124

Description

EF 9 brings many improvements to SQL generation (list). One of these, which also improves query performance, applies bit arithmetic (XOR) to implement equality in contexts where SQL Server requires a BIT value (as opposed to a search condition, so projected SELECT values rather than WHERE predicates).

Unfortunately, the SQL optimization was implemented too widely, applying also on value-converted values, which is incorrect.

Customer impact

Queries on SQL Server which involve equality with a value-converted value sometimes generate invalid SQL and fail. For example:

_ = await context.Orders
    .Select(order => new { Paid = order.State == OrderState.Paid })
    // The following is OK (non-value-converted string)
    // .Select(order => new { IsNameFoo = order.Name == "Foo" })
    .ToListAsync();

This scenario is particularly common with value-converted enums, and so has the potential to affect many users. The fix is trivial and low-risk.

How found

Customer reported on 9.

Regression

Yes, from 8.

Testing

Tests added.

Risk

Low and quirked.

/cc @ranma42

[roji]

Servicing approved via email.

[SurgeOccm]

Sorry, team: is this fix already released to general audience? I upgraded my .NET 8 API project to .NET 9 today and immediately started getting loads of errors on SQL server side with this very issue in the scope. Since all of my EF statements are auto-generated with Hot Chocolate 14 instead of manually constructed, I have no control over it and rely on your fix in the EF Core that you were discussing. Is this already released and can be pulled via Nuget package update yet?

[AndriySvyryd]

@SurgeOccm It will be released this month in 9.0.1

[SurgeOccm]

@SurgeOccm It will be released this month in 9.0.1

Thank you Andriy, very much appreciated!