-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update to SQLitePCLRaw 3.x #36551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to SQLitePCLRaw 3.x #36551
Conversation
…w bundles for e_sqlcipher, e_sqlite3mc, winsqlite3, and plain sqlite3, are no longer supported. so for now, the corresponding test suites have been removed from the sln file. the winsqlite3 and plain sqlite3 test suites can be brought back by using the SQLitePCLRaw provider directly, but those packages don't seem to be available to this build system yet. the test suites for crypto-enabled SQLite would require some other approach, as I no longer publish SQLite builds with crypto at no cost.
I discussed this with the team and we think that at this point it's too risky to do this for 10, instead we could do it early for 11 (next week) so we have time to gather feedback and prepare upgrade documentation. |
Acknowledged. Thanks for the update. |
@ericsink On Linux it is failing with |
I will investigate. Thanks for highlighting the error. |
I see the problem with my package, but I'm not quite seeing how it would happen, and I want to make sure I'm not missing something. The test suite must be running on (or building for) a number of different Linux configurations, and |
As far as I'm aware, we're building only for |
Hmmm. Then the error message is a bit of a mystery then. I'll dig more. Thanks. |
I found the problem. My mistake. Fix pending. |
I'm taking the opportunity to fix some other problems with the targets file. I should be updating this PR next week. |
See #36535
This PR updates the package reference for SQLitePCLRaw to 3.0.1.
The most significant aspect of this change: Because the e_sqlcipher and e_sqlite3mc bundles have been deprecated, I have removed the corresponding test programs from EFCore.sln. However, their respective csproj files are still present.