Skip to content

Conversation

ericsink
Copy link

See #36535

This PR updates the package reference for SQLitePCLRaw to 3.0.1.

The most significant aspect of this change: Because the e_sqlcipher and e_sqlite3mc bundles have been deprecated, I have removed the corresponding test programs from EFCore.sln. However, their respective csproj files are still present.

…w bundles for e_sqlcipher, e_sqlite3mc, winsqlite3, and plain sqlite3, are no longer supported. so for now, the corresponding test suites have been removed from the sln file. the winsqlite3 and plain sqlite3 test suites can be brought back by using the SQLitePCLRaw provider directly, but those packages don't seem to be available to this build system yet. the test suites for crypto-enabled SQLite would require some other approach, as I no longer publish SQLite builds with crypto at no cost.
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 11, 2025

I discussed this with the team and we think that at this point it's too risky to do this for 10, instead we could do it early for 11 (next week) so we have time to gather feedback and prepare upgrade documentation.

@ericsink
Copy link
Author

Acknowledged. Thanks for the update.

@ericsink ericsink requested a review from a team as a code owner August 13, 2025 16:47
@cincuranet
Copy link
Contributor

cincuranet commented Aug 20, 2025

@ericsink On Linux it is failing with /home/vsts/work/1/s/.dotnet/sdk/10.0.100-rc.1.25411.109/Microsoft.Common.CurrentVersion.targets(5381,5): error MSB3030: Could not copy the file "/home/vsts/work/1/s/.packages/sourcegear.sqlite3/3.50.3/runtimes/linux-riscv64/native/libe_sqlite3.so" because it was not found. [/home/vsts/work/1/s/test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.Tests.csproj::TargetFramework=net481] (link).

@ericsink
Copy link
Author

I will investigate. Thanks for highlighting the error.

@ericsink
Copy link
Author

I see the problem with my package, but I'm not quite seeing how it would happen, and I want to make sure I'm not missing something.

The test suite must be running on (or building for) a number of different Linux configurations, and linux-riscv64 is apparently one of them. Is that list of configurations or RIDs in the repo somewhere so I can verify any others that might cause problems?

@cincuranet
Copy link
Contributor

As far as I'm aware, we're building only for linux-x64.

@ericsink
Copy link
Author

Hmmm. Then the error message is a bit of a mystery then. I'll dig more. Thanks.

@ericsink
Copy link
Author

I found the problem. My mistake. Fix pending.

@ericsink
Copy link
Author

I'm taking the opportunity to fix some other problems with the targets file. I should be updating this PR next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants