[GA] Use temporary memory database connection to quote the password. #36962
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamMonoRT
approved these changes
Oct 14, 2025
artl93
approved these changes
Oct 14, 2025
This was referenced Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36956 and #36961.
Description
SQLite introduced change in 3.48.0 in how encrypted databases are allowed to access - now even statements not actually touching database itself have to go through de-encryption. Because we quote the password using
SELECT quote($password)statement, this started failing. This change uses temporary in-memory database connection to execute this statement.Customer impact
Failure when trying to open encrypted database (even with correct password) on 3.48.0 or newer.
How found
Customer reported.
Regression
No.
Testing
Tests already present. This is change is required because of change in underlying SQLite.
Risk
Low.