Skip to content

Fallback to OPENJSON with many parameters #37234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fallback to OPENJSON with many parameters #37234

wants to merge 15 commits into from

Conversation

@cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Nov 24, 2025

Fixes #37185.

roji
roji reviewed Nov 25, 2025
View reviewed changes
@cincuranet cincuranet marked this pull request as ready for review December 1, 2025 12:19
@cincuranet cincuranet requested a review from a team as a code owner December 1, 2025 12:19
@cincuranet cincuranet requested a review from roji December 1, 2025 12:19
roji
roji requested changes Dec 1, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, see comments for some minor fixes.

@cincuranet cincuranet requested a review from roji December 2, 2025 13:23
roji
roji approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are adddressed (see specifically that possible inverse logic bug).

@SamMonoRT
Copy link
Member

SamMonoRT commented Dec 2, 2025

@cincuranet - confirming this is targetting main and we will backport a fix as necessary.

@cincuranet
Copy link
Contributor Author

cincuranet commented Dec 2, 2025 •
edited
Loading

@SamMonoRT Yes. And for sure we'll backport.

roji
roji approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @cincuranet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Contains fails to fallback to OPENJSON with many parameters in complex queries

3 participants

@cincuranet @SamMonoRT @roji