[release/9.0] Fix snapshot generation to capture column type for JSON columns #37294
+149
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of #37284 without complex types) Co-authored-by: AndriySvyryd <[email protected]>
Copilot
AI
changed the title
[WIP] Port changes from PR #37284 to release/9.0-staging
Port #37284 to release/9.0-staging: Fix snapshot generation for JSON column types
Dec 4, 2025
Copilot finished work on behalf of
AndriySvyryd
December 4, 2025 00:33
AndriySvyryd
changed the title
AndriySvyryd
changed the title
SamMonoRT
approved these changes
Dec 5, 2025
cincuranet
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #37284
Description
EF Core 10 added support for
jsonSQL Server type for JSON column and it's used by default if the target SQL Server version supports, but no migrations to convert the columns to the newjsoncolumn type are created because the model snapshot doesn't capture the default store type for JSON columns.Customer impact
Customers upgrading from EF Core 9 to 10 who use
ToJson()won't get migrations generated to update the column type fromnvarchar(max)tojson. The workaround is to manually specify.HasColumnType("json")on the JSON column.How found
Customer reported on EF 10.0.0
Regression
No, new feature.
Testing
Test added
Risk
Low. Targeted fix to include the default column type in the model snapshot. Only affects design-time.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.