[release/10.0] Allow tools to run on projects targeting multiple frameworks #37301
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the dotnet ef tool fails for projects targeting multiple target frameworks (multi-TFM). The fix passes framework, configuration, and runtime parameters to Project.FromFile() for both the main project and startup project, and adds a helpful error message when multi-TFM projects are detected without a specified framework.
Key changes:
- Modified
RootCommand.csto pass framework/configuration/runtime parameters to both project and startup project initialization - Added
HasMultipleTargetFrameworks()helper method to detect multi-TFM scenarios and provide a clear error message - Added
MultipleTargetFrameworksresource string for the new error message
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dotnet-ef/RootCommand.cs | Updated to pass framework/configuration/runtime parameters to Project.FromFile() for the main project, matching the existing startup project initialization |
| src/dotnet-ef/Properties/Resources.resx | Added new error message resource for multi-TFM scenario |
| src/dotnet-ef/Properties/Resources.Designer.cs | Generated code for new resource string and minor documentation improvement for NativeAotDescription |
| src/dotnet-ef/Project.cs | Added HasMultipleTargetFrameworks() method to detect multi-TFM projects and improved error handling with specific message |
Files not reviewed (1)
- src/dotnet-ef/Properties/Resources.Designer.cs: Language not supported
AndriySvyryd
changed the title
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37230
Description
For EF 10 we started relying on the
ResolvePackageAssetsMSBuild task to get more accurate information about the project dependencies. However, this task is not available if the project is targeting multiple TFMs. The solution is to allow users to select which framework should be used.Customer impact
Fir apps targeting multiple TFMs the ef tool will throw an exception when any command is invoked. The workaround to change the project to target a single TFM temporarily. However, this isn't possible in CI/CD scenarios.
How found
Multiple customer reports on EF 10.
Regression
Yes, from EF 9
Testing
Tested manually.
Risk
Low. Targeted fix that only affects design-time tools.