Skip to content

[release/10.0] Fix path separator issue on Linux/macOS in dotnet-ef tools #37519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: release/10.0
Choose a base branch
from
+10 −7
Open

[release/10.0] Fix path separator issue on Linux/macOS in dotnet-ef tools #37519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7da66d
Initial plan
Copilot Jan 15, 2026
7b3adaa
Fix path separator issue on Linux/macOS in dotnet-ef tools (#37506)
Copilot Jan 15, 2026
8796083
Consolidate path normalization in Project.cs
Copilot Jan 15, 2026
b92db72
Apply path normalization to DesignAssembly, ProjectAssetsFile and Pro…
Copilot Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/dotnet-ef/Project.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,14 @@ public static Project FromFile(

var designAssembly = runtimeCopyLocalItems
.Select(i => i["FullPath"])
.FirstOrDefault(i => i.Contains("Microsoft.EntityFrameworkCore.Design", StringComparison.InvariantCulture));
.FirstOrDefault(i => i.Contains("Microsoft.EntityFrameworkCore.Design", StringComparison.InvariantCulture))
?.Replace('\\', Path.DirectorySeparatorChar);
var properties = metadata.Properties;

var outputPath = Path.GetFullPath(Path.Combine(properties[nameof(ProjectDir)]!, properties[nameof(OutputPath)]!));
var normalizedOutputPath = properties[nameof(OutputPath)]!.Replace('\\', Path.DirectorySeparatorChar);
var normalizedProjectDir = properties[nameof(ProjectDir)]!.Replace('\\', Path.DirectorySeparatorChar);
var normalizedProjectAssetsFile = properties[nameof(ProjectAssetsFile)]?.Replace('\\', Path.DirectorySeparatorChar);
var outputPath = Path.GetFullPath(Path.Combine(normalizedProjectDir, normalizedOutputPath));
CopyBuildHost(runtimeCopyLocalItems, outputPath);

var platformTarget = properties[nameof(PlatformTarget)];
Expand All @@ -116,10 +120,10 @@ public static Project FromFile(
AssemblyName = properties[nameof(AssemblyName)],
DesignAssembly = designAssembly,
Language = properties[nameof(Language)],
OutputPath = properties[nameof(OutputPath)],
OutputPath = normalizedOutputPath,
PlatformTarget = platformTarget,
ProjectAssetsFile = properties[nameof(ProjectAssetsFile)],
ProjectDir = properties[nameof(ProjectDir)],
ProjectAssetsFile = normalizedProjectAssetsFile,
ProjectDir = normalizedProjectDir,
RootNamespace = properties[nameof(RootNamespace)],
RuntimeFrameworkVersion = properties[nameof(RuntimeFrameworkVersion)],
TargetFileName = properties[nameof(TargetFileName)],
Expand Down
3 changes: 1 addition & 2 deletions src/dotnet-ef/RootCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ protected override int Execute(string[] _)
Path.GetDirectoryName(typeof(Program).Assembly.Location)!,
"tools");

var targetDir = Path.GetFullPath(Path.Combine(startupProject.ProjectDir!, startupProject.OutputPath!))
.Replace('\\', Path.DirectorySeparatorChar);
var targetDir = Path.GetFullPath(Path.Combine(startupProject.ProjectDir!, startupProject.OutputPath!));
var targetPath = Path.Combine(targetDir, project.TargetFileName!);
var startupTargetPath = Path.Combine(targetDir, startupProject.TargetFileName!);
var depsFile = Path.Combine(
Expand Down