-
Notifications
You must be signed in to change notification settings - Fork 825
Type abbreviation mismatch extended data #16811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type abbreviation mismatch extended data #16811
Conversation
❗ Release notes required
|
@DedSec256 would be nice if you could review this PR as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! :)
In general, LGTM, there are just few comments
Thanks for the review @DedSec256! |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Just to understand, what are the applicable scenarios here? From my experience (don't want to generalize), type abbreviations are often used for things like I mean I know that it was like this before, just curious if we can be even more specific in the diagnostics here. |
Basically any type alias: // sig
type Foo = X
// impl
type Foo = Y Today, we get a diagnostic that there is a mismatch ( To perform some code fix like: I can pull this off, but this PR makes it a lot more easy to do it. |
The body is irrelevant in this case, so I'm not sure what other scenarios you feel are lacking. |
…thub.com/nojaf/fsharp into type-abbreviation-mismatch-extended-data
Description
Similar to the extended data added in #15840 I want to know the location of the types (in sig/impl) when an abbreviation is mismatched.
I later want to create a quick fix to update the signature file when necessary:

Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: