Skip to content

Unify let, let!, use, use! LetOrUse AST representation. #18816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edgarfgp wants to merge 38 commits into from

Update CheckComputationExpressions.fs

f960746
Select commit
Loading
Failed to load commit list.
Closed

Unify let, let!, use, use! LetOrUse AST representation. #18816

Update CheckComputationExpressions.fs
f960746
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci (Build WindowsCompressedMetadata fsharpqa_release) failed Aug 5, 2025 in 7m 10s

Build WindowsCompressedMetadata fsharpqa_release failed

85 errors / 1 warnings

Annotations

Check failure on line 1531 in src\FSharp.Core\async.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsCompressedMetadata fsharpqa_release)

src\FSharp.Core\async.fs#L1531 

src\FSharp.Core\async.fs(1531,48): error FS0001: (NETCORE_ENGINEERING_TELEMETRY=Build) This expression was expected to have type    'CancellationToken'    but here has type    'Async<CancellationToken>'

Check failure on line 1924 in src\FSharp.Core\async.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsCompressedMetadata fsharpqa_release)

src\FSharp.Core\async.fs#L1924 

src\FSharp.Core\async.fs(1924,44): error FS0001: (NETCORE_ENGINEERING_TELEMETRY=Build) This expression was expected to have type    'AsyncResult<'a>'    but here has type    'Async<AsyncResult<'T>>'

Check failure on line 1958 in src\FSharp.Core\async.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsCompressedMetadata fsharpqa_release)

src\FSharp.Core\async.fs#L1958 

src\FSharp.Core\async.fs(1958,28): error FS0001: (NETCORE_ENGINEERING_TELEMETRY=Build) This expression was expected to have type    'bool'    but here has type    'Async<bool>'

Check failure on line 1980 in src\FSharp.Core\async.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsCompressedMetadata fsharpqa_release)

src\FSharp.Core\async.fs#L1980 

src\FSharp.Core\async.fs(1980,20): error FS0039: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'Async<_>' does not define the field, constructor or member 'Register'.

Check failure on line 2071 in src\FSharp.Core\async.fs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci (Build WindowsCompressedMetadata fsharpqa_release)

src\FSharp.Core\async.fs#L2071 

src\FSharp.Core\async.fs(2071,20): error FS0039: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'Async<_>' does not define the field, constructor or member 'Register'.
View more details on Azure Pipelines