Skip to content

Fix object expressions in struct types generating invalid IL with byref fields #19070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 22 commits into
base: main
Choose a base branch
from
+417 −2

Fix TcGlobals type reference to use fully qualified name

3d761aa
Select commit
Loading
Failed to load commit list.
Draft

Fix object expressions in struct types generating invalid IL with byref fields #19070

Fix TcGlobals type reference to use fully qualified name
3d761aa
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Dec 31, 2025 in 54m 6s

Build #20251231.18 had test failures

24 errors / 4 warnings

Details

Tests

  • Failed: 21 (0.02%)
  • Passed: 88,307 (97.54%)
  • Other: 2,204 (2.43%)
  • Total: 90,532

Annotations

Check failure on line 16 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L16 

Bash exited with code '99'.

Check failure on line 4509 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4509 

(NETCORE_ENGINEERING_TELEMETRY=Test) Error running tests (exit code '1').

Check failure on line 4511 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4511 

Bash exited with code '1'.

Check failure on line 4517 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4517 

(NETCORE_ENGINEERING_TELEMETRY=Test) Error running tests (exit code '1').

Check failure on line 1 in FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct should not generate byref field - simple case

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct should not generate byref field - simple case 

System.Exception : Eval or Execution has failed (expected to succeed): StopProcessingExn
All errors:
{ Error = Error 222
  Range = { StartLine = 2
            StartColumn = 0
            EndLine = 3
            EndColumn = 0 }
  NativeRange = (2,0--3,0)
  Message =
   "Files in libraries or multiple-file applications must begin with a namespace or module declaration, e.g. 'namespace SomeNamespace.SubNamespace' or 'module SomeNamespace.SomeModule'. Only the last source file of an application may omit such a declaration."
  SubCategory = "parse" }
Raw output 
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in /Users/runner/work/1/s/src/FSharp.Core/printf.fs:line 1397
   at FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct should not generate byref field - simple case() in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Conformance/Expressions/ObjectExpressions/StructObjectExpression.fs:line 24
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct with multiple fields

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct with multiple fields 

System.Exception : Eval or Execution has failed (expected to succeed): StopProcessingExn
All errors:
{ Error = Error 222
  Range = { StartLine = 2
            StartColumn = 0
            EndLine = 3
            EndColumn = 0 }
  NativeRange = (2,0--3,0)
  Message =
   "Files in libraries or multiple-file applications must begin with a namespace or module declaration, e.g. 'namespace SomeNamespace.SubNamespace' or 'module SomeNamespace.SomeModule'. Only the last source file of an application may omit such a declaration."
  SubCategory = "parse" }
Raw output 
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in /Users/runner/work/1/s/src/FSharp.Core/printf.fs:line 1397
   at FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct with multiple fields() in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Conformance/Expressions/ObjectExpressions/StructObjectExpression.fs:line 42
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct referencing field in override method

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct referencing field in override method 

System.Exception : Eval or Execution has failed (expected to succeed): StopProcessingExn
All errors:
{ Error = Error 222
  Range = { StartLine = 2
            StartColumn = 0
            EndLine = 3
            EndColumn = 0 }
  NativeRange = (2,0--3,0)
  Message =
   "Files in libraries or multiple-file applications must begin with a namespace or module declaration, e.g. 'namespace SomeNamespace.SubNamespace' or 'module SomeNamespace.SomeModule'. Only the last source file of an application may omit such a declaration."
  SubCategory = "parse" }
Raw output 
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in /Users/runner/work/1/s/src/FSharp.Core/printf.fs:line 1397
   at FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct referencing field in override method() in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Conformance/Expressions/ObjectExpressions/StructObjectExpression.fs:line 62
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct with multiple fields

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct with multiple fields 

System.Exception : Eval or Execution has failed (expected to succeed): StopProcessingExn
All errors:
{ Error = Error 222
  Range = { StartLine = 2
            StartColumn = 0
            EndLine = 3
            EndColumn = 0 }
  NativeRange = (2,0--3,0)
  Message =
   "Files in libraries or multiple-file applications must begin with a namespace or module declaration, e.g. 'namespace SomeNamespace.SubNamespace' or 'module SomeNamespace.SomeModule'. Only the last source file of an application may omit such a declaration."
  SubCategory = "parse" }
Raw output 
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in D:\a\_work\1\s\src\FSharp.Core\printf.fs:line 1397
   at FSharp.Compiler.ComponentTests.Conformance.Expressions.StructObjectExpression.Object expression in struct with multiple fields() in D:\a\_work\1\s\tests\FSharp.Compiler.ComponentTests\Conformance\Expressions\ObjectExpressions\StructObjectExpression.fs:line 42
View more details on Azure Pipelines