Skip to content

Implement fix for voption with optional parameter syntax (?x=)

b1a7969
Select commit
Loading
Failed to load commit list.
Closed

WIP: Add tests for issue #19074 - voption with optional parameter syntax (?x=) #19076

Implement fix for voption with optional parameter syntax (?x=)
b1a7969
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Nov 13, 2025 in 51m 39s

Build #20251113.11 had test failures

Details

Tests

  • Failed: 10 (0.01%)
  • Passed: 104,428 (97.86%)
  • Other: 2,276 (2.13%)
  • Total: 106,714

Annotations

Check failure on line 428 in .packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25562.6\tools\Publish.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25562.6\tools\Publish.proj#L428

.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25562.6\tools\Publish.proj(428,5): error : (NETCORE_ENGINEERING_TELEMETRY=Publish) ItemsToPush is not specified.

Check failure on line 4875 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4875

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 4876 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4876

Cmd.exe exited with code '1'.

Check failure on line 4927 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4927

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 1 in FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with option optional parameter should still work with question mark syntax

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with option optional parameter should still work with question mark syntax

System.Exception : Mismatch in Errors, expected '0', got '1'.
All errors:
[(Error 1, Line 12, Col 23, Line 12, Col 25, "This expression was expected to have type
    'int option'    
but here has type
    'int'    ")]
Raw output
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in D:\a\_work\1\s\src\FSharp.Core\printf.fs:line 1397
   at FSharp.Test.CompilerAssertHelpers.assertErrors(Int32 libAdjust, Boolean ignoreWarnings, FSharpDiagnostic[] errors, Tuple`4[] expectedErrors) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 503
   at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.CompileWithErrors@698.Invoke(Tuple`2 tupledArg) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 699
   at FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with option optional parameter should still work with question mark syntax() in D:\a\_work\1\s\tests\fsharp\Compiler\Language\OptionalInteropTests.fs:line 247

Check failure on line 1 in FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with option optional parameter should still work with question mark syntax

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with option optional parameter should still work with question mark syntax

System.Exception : Mismatch in Errors, expected '0', got '1'.
All errors:
[(Error 1, Line 12, Col 23, Line 12, Col 25, "This expression was expected to have type
    'int option'    
but here has type
    'int'    ")]
Raw output
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in D:\a\_work\1\s\src\FSharp.Core\printf.fs:line 1397
   at FSharp.Test.CompilerAssertHelpers.assertErrors(Int32 libAdjust, Boolean ignoreWarnings, FSharpDiagnostic[] errors, Tuple`4[] expectedErrors) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 503
   at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.CompileWithErrors@698.Invoke(Tuple`2 tupledArg) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 699
   at FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with option optional parameter should still work with question mark syntax() in D:\a\_work\1\s\tests\fsharp\Compiler\Language\OptionalInteropTests.fs:line 247

Check failure on line 1 in FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with voption optional parameter should accept ValueSome with question mark syntax

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with voption optional parameter should accept ValueSome with question mark syntax

System.Exception : Mismatch in Errors, expected '0', got '1'.
All errors:
[(Error 1, Line 11, Col 28, Line 11, Col 30, "This expression was expected to have type
    'int voption'    
but here has type
    'int'    ")]
Raw output
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in D:\a\_work\1\s\src\FSharp.Core\printf.fs:line 1397
   at FSharp.Test.CompilerAssertHelpers.assertErrors(Int32 libAdjust, Boolean ignoreWarnings, FSharpDiagnostic[] errors, Tuple`4[] expectedErrors) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 503
   at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.CompileWithErrors@698.Invoke(Tuple`2 tupledArg) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 699
   at FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with voption optional parameter should accept ValueSome with question mark syntax() in D:\a\_work\1\s\tests\fsharp\Compiler\Language\OptionalInteropTests.fs:line 205

Check failure on line 1 in FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with voption optional parameter should accept ValueSome with question mark syntax

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with voption optional parameter should accept ValueSome with question mark syntax

System.Exception : Mismatch in Errors, expected '0', got '1'.
All errors:
[(Error 1, Line 11, Col 28, Line 11, Col 30, "This expression was expected to have type
    'int voption'    
but here has type
    'int'    ")]
Raw output
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in D:\a\_work\1\s\src\FSharp.Core\printf.fs:line 1397
   at FSharp.Test.CompilerAssertHelpers.assertErrors(Int32 libAdjust, Boolean ignoreWarnings, FSharpDiagnostic[] errors, Tuple`4[] expectedErrors) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 503
   at <StartupCode$FSharp-Test-Utilities>.$CompilerAssert.CompileWithErrors@698.Invoke(Tuple`2 tupledArg) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\CompilerAssert.fs:line 699
   at FSharp.Compiler.UnitTests.OptionalInteropTests.F# method with voption optional parameter should accept ValueSome with question mark syntax() in D:\a\_work\1\s\tests\fsharp\Compiler\Language\OptionalInteropTests.fs:line 205