Skip to content

Fix nullness warning in TryParseFeature by using box before downcast

2e3f35c
Select commit
Loading
Failed to load commit list.
Merged

Add --disableLanguageFeature CLI switch and MSBuild property to selectively disable language features #19167

Fix nullness warning in TryParseFeature by using box before downcast
2e3f35c
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Dec 19, 2025 in 1h 48m 35s

Build #20251219.3 had test failures

Details

Tests

  • Failed: 34 (0.04%)
  • Passed: 88,266 (97.53%)
  • Other: 2,204 (2.44%)
  • Total: 90,504

Annotations

Check failure on line 4938 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4938

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 4939 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L4939

Cmd.exe exited with code '1'.

Check failure on line 428 in .packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25615.1\tools\Publish.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25615.1\tools\Publish.proj#L428

.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25615.1\tools\Publish.proj(428,5): error : (NETCORE_ENGINEERING_TELEMETRY=Publish) ItemsToPush is not specified.

Check failure on line 6635 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L6635

PowerShell exited with code '1'.

Check failure on line 1 in CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature can be used multiple times

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature can be used multiple times

System.Exception : Mismatch in ErrorNumber, expected '39' was not found during compilation.
All errors:
["Error 193 "internal error: The given key was not present in the dictionary.""]
Raw output
   at FSharp.Test.Compiler.Assertions.assertErrorNumbers(FSharpList`1 source, FSharpList`1 expected) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\Compiler.fs:line 1660
   at FSharp.Test.Compiler.Assertions.checkCodes(FSharpList`1 expected, FSharpFunc`2 selector, CompilationResult result) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\Compiler.fs:line 1859
   at FSharp.Test.Compiler.Assertions.withErrorCode(Int32 expectedCode, CompilationResult result) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\Compiler.fs:line 1865
   at CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature can be used multiple times() in D:\a\_work\1\s\tests\FSharp.Compiler.ComponentTests\CompilerOptions\fsc\disableLanguageFeature.fs:line 55

Check failure on line 1 in CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature with valid feature name should typecheck successfully

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature with valid feature name should typecheck successfully

System.Exception : Operation failed (expected to succeed).
All errors:
{ Error = Error 193
  Range = { StartLine = 1
            StartColumn = 0
            EndLine = 1
            EndColumn = 0 }
  NativeRange = (1,0--1,0)
  Message = "internal error: The given key was not present in the dictionary."
  SubCategory = "parameter" } 
 OUTPUTs: None
Raw output
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1447.Invoke(String message)
   at Microsoft.FSharp.Core.PrintfModule.gprintf[a,TState,TResidue,TResult,TPrinter](FSharpFunc`2 envf, PrintfFormat`4 format) in D:\a\_work\1\s\src\FSharp.Core\printf.fs:line 1397
   at CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature with valid feature name should typecheck successfully() in D:\a\_work\1\s\tests\FSharp.Compiler.ComponentTests\CompilerOptions\fsc\disableLanguageFeature.fs:line 18

Check failure on line 1 in FSharp.Compiler.Service.Tests.ConsoleOnlyOptionsTests.fsc help text is displayed correctly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.Service.Tests.ConsoleOnlyOptionsTests.fsc help text is displayed correctly

Assert.Equal() Failure: Strings differ
                                    ↓ (pos 7761)
Expected: ···"t' or 'preview'.\r\n--checked[+|-]         "···
Actual:   ···"t' or 'preview'.\r\n--disableLanguageFeatur"···
                                    ↑ (pos 7761)
Raw output
   at FSharp.Compiler.Service.Tests.ConsoleOnlyOptionsTests.fsc help text is displayed correctly() in D:\a\_work\1\s\tests\FSharp.Compiler.Service.Tests\ConsoleOnlyOptionsTests.fs:line 26

Check failure on line 1 in CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature is case insensitive

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature is case insensitive

System.Exception : Mismatch in ErrorNumber, expected '39' was not found during compilation.
All errors:
["Error 193 "internal error: The given key was not present in the dictionary.""]
Raw output
   at FSharp.Test.Compiler.Assertions.assertErrorNumbers(FSharpList`1 source, FSharpList`1 expected) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\Compiler.fs:line 1660
   at FSharp.Test.Compiler.Assertions.checkCodes(FSharpList`1 expected, FSharpFunc`2 selector, CompilationResult result) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\Compiler.fs:line 1859
   at FSharp.Test.Compiler.Assertions.withErrorCode(Int32 expectedCode, CompilationResult result) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\Compiler.fs:line 1865
   at CompilerOptions.Fsc.disableLanguageFeature.disableLanguageFeature is case insensitive() in D:\a\_work\1\s\tests\FSharp.Compiler.ComponentTests\CompilerOptions\fsc\disableLanguageFeature.fs:line 67