Skip to content

Modify expiration dates in .gdnbaselines #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Modify expiration dates in .gdnbaselines #7518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .config/guardian/.gdnbaselines
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"tool": "psscriptanalyzer",
"ruleId": "PSAvoidUsingUsernameAndPasswordParams",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have control over external components.

We do have control over eng/common/SetupNugetSources.ps1 that's from arcade. Maybe we should delete this one?

"createdDate": "2024-03-06 21:08:31Z",
"expirationDate": "2024-08-23 23:30:43Z",
"expirationDate": "2026-12-31T23:59:59Z",
Comment on lines 26 to +27
Copy link
Preview

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timestamp formats are inconsistent: createdDate uses a space (YYYY-MM-DD HH:MM:SSZ) while expirationDate uses ISO 8601 with 'T'. Standardize on one format (prefer full ISO 8601 or existing project convention) to avoid parsing or readability issues. Apply consistently to all updated expirationDate entries.

Copilot uses AI. Check for mistakes.

"justification": "This error is baselined with an expiration date of 180 days from 2024-03-06 23:30:43Z"
Comment on lines +27 to 28
Copy link
Preview

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification text states a 180-day expiration from 2024-03-06, which would place expiration in 2024, but the updated expirationDate is 2026-12-31. Update the justification to reflect the new long-term date or adjust the expirationDate to match the stated 180-day policy.

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krwq should we update this too? Another option would be to copy the file from an internal PR which we dismiss. I think that's how we created this to begin with.

},
"992b26983b997813a410dfc25048f3b218c6fc02fc14a5c2ad431ec8e022ac79": {
Expand All @@ -40,7 +40,7 @@
"tool": "psscriptanalyzer",
"ruleId": "PSAvoidUsingUsernameAndPasswordParams",
"createdDate": "2024-03-06 21:08:31Z",
"expirationDate": "2024-08-23 23:30:43Z",
"expirationDate": "2026-12-31T23:59:59Z",
"justification": "This error is baselined with an expiration date of 180 days from 2024-03-06 23:30:43Z"
Copy link
Preview

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification text states a 180-day expiration from 2024-03-06, which would place expiration in 2024, but the updated expirationDate is 2026-12-31. Update the justification to reflect the new long-term date or adjust the expirationDate to match the stated 180-day policy.

Copilot uses AI. Check for mistakes.

},
"53b10a5fb6059b0b229ad32c6278123a5603386f65d9e1c5684a2333f2e1dc62": {
Expand All @@ -56,7 +56,7 @@
"tool": "psscriptanalyzer",
"ruleId": "PSAvoidUsingUsernameAndPasswordParams",
"createdDate": "2024-03-06 21:08:31Z",
"expirationDate": "2024-08-23 23:30:43Z",
"expirationDate": "2026-12-31T23:59:59Z",
"justification": "This error is baselined with an expiration date of 180 days from 2024-03-06 23:30:43Z"
Copy link
Preview

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification text states a 180-day expiration from 2024-03-06, which would place expiration in 2024, but the updated expirationDate is 2026-12-31. Update the justification to reflect the new long-term date or adjust the expirationDate to match the stated 180-day policy.

Copilot uses AI. Check for mistakes.

},
"2c5f3fa8b37f6dfb1ec7cb1bc64d39a43a9a0184f317d7bd5811d734da9c8626": {
Expand All @@ -71,7 +71,7 @@
"tool": "binskim",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These for MKLImports are effectively an external component the way it's built today. This is a custom build of intel MKL where we cannot modify much of the pipeline. I have discussed building this in our pipeline -- we were blocked on this in the past due to the size of the toolset used to produce it -- but there may be options to build from nuget packages containing the MKL libs. Even so, we wouldn't be able to apply any compiler flags since we just link libraries provided by Intel.

We also have other components we redistribute but don't build ourselves

  • OneDAL (we build OneDalNative, but many Intel onedal binaries are redistributed with it)
  • libiomp (dependency of MKL)

"ruleId": "BA2008",
"createdDate": "2024-03-06 21:13:53Z",
"expirationDate": "2024-08-23 23:30:43Z",
"expirationDate": "2026-12-31T23:59:59Z",
"justification": "This error is baselined with an expiration date of 180 days from 2024-03-06 23:30:43Z"
Copy link
Preview

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification text states a 180-day expiration from 2024-03-06, which would place expiration in 2024, but the updated expirationDate is 2026-12-31. Update the justification to reflect the new long-term date or adjust the expirationDate to match the stated 180-day policy.

Copilot uses AI. Check for mistakes.

},
"17d4115eadce781703d1e090f3c05e73f84fbbab513a1d4c8cd60b54dc8efe8c": {
Expand All @@ -86,8 +86,8 @@
"tool": "binskim",
"ruleId": "BA2008",
"createdDate": "2024-03-06 21:36:33Z",
"expirationDate": "2024-08-23 23:30:43Z",
"expirationDate": "2026-12-31T23:59:59Z",
"justification": "This error is baselined with an expiration date of 180 days from 2024-03-06 23:30:43Z"
Copy link
Preview

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification text states a 180-day expiration from 2024-03-06, which would place expiration in 2024, but the updated expirationDate is 2026-12-31. Update the justification to reflect the new long-term date or adjust the expirationDate to match the stated 180-day policy.

Copilot uses AI. Check for mistakes.

}
}
}
}