Skip to content

Improve unique directory generation for temp files #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −4
Open

Improve unique directory generation for temp files #7520

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45d4316
Improve unique directory generation for temp files
ericstj Oct 3, 2025
1a4856c
Update src/Microsoft.ML.Core/Data/Repository.cs
tarekgh Oct 3, 2025
17733bb
Fix build
ericstj Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Microsoft.ML.Core/Data/Repository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,14 @@ private static string GetShortTempDir(IExceptionContext ectx)
string tempPath = ectx is IHostEnvironmentInternal iHostInternal ?
iHostInternal.TempFilePath :
Path.GetTempPath();
int dirNumber = 0;
string mlNetTempDir = null!;
while (Directory.Exists(mlNetTempDir = Path.Combine(Path.GetFullPath(tempPath), $"ml_dotnet{dirNumber++}"))) ;
var path = Path.Combine(mlNetTempDir, Path.GetRandomFileName());

// Find a unique directory, the directory under Temp and must be unique to this process
string path = null;
while (path is null || Directory.Exists(path))
{
path = Path.Combine(Path.GetFullPath(tempPath), $"ml_dotnet_{Path.GetRandomFileName()}");
}

Directory.CreateDirectory(path);
return path;
}
Expand Down
Loading