[tests] We must set 'UseFloatingTargetPlatformVersion=true' for our test projects, to avoid building them with other workloads than the current workload. #24281

rolfbjarne · 2025-11-18T12:41:27Z

Also the ComputeRemoteGeneratorProperties task needs to know the value of
UseFloatingTargetPlatformVersion, so that it can be passed on when executing
dotnet to compute binding variables, because otherwise we might end up with
variables from the wrong workload.

…est projects, to avoid building them with other workloads than the current workload.

… value of UseFloatingTargetPlatformVersion. So that it can be passed on when executing `dotnet` to compute binding variables, because otherwise we might end up with variables from the wrong workload.

…ClassLibrary' test.

…s as well.

Copilot

Pull Request Overview

This PR ensures that test projects build with the correct workload by setting UseFloatingTargetPlatformVersion=true. This prevents tests from inadvertently building with other workloads than the current one.

Centralized UseFloatingTargetPlatformVersion=true in GetDefaultProperties() method to apply to all test builds
Updated all test methods to use GetDefaultProperties() instead of manually creating property dictionaries
Added UseFloatingTargetPlatformVersion parameter to ComputeRemoteGeneratorProperties task to propagate the property when computing binding variables
Set default value in shared-dotnet.csproj for all test projects

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/dotnet/UnitTests/TestBaseClass.cs	Added `UseFloatingTargetPlatformVersion=true` to `GetDefaultProperties()` method
tests/dotnet/UnitTests/XcodeProjectTests.cs	Updated all test methods to use `GetDefaultProperties()` instead of manual property dictionaries
tests/dotnet/UnitTests/TemplateTest.cs	Updated template test methods to use `GetDefaultProperties()`
tests/dotnet/UnitTests/ProjectTest.cs	Added exception for `BuildMyClassLibrary` test which explicitly verifies workload behavior
tests/common/shared-dotnet.csproj	Set default `UseFloatingTargetPlatformVersion=true` for all test projects
msbuild/Xamarin.Shared/Xamarin.Shared.targets	Passed `UseFloatingTargetPlatformVersion` parameter to `ComputeRemoteGeneratorProperties` task
msbuild/Xamarin.MacDev.Tasks/Tasks/ComputeRemoteGeneratorProperties.cs	Added `UseFloatingTargetPlatformVersion` property and passed it as MSBuild argument when computing properties

tests/dotnet/UnitTests/TestBaseClass.cs

…ng-tpv

Co-authored-by: Copilot <[email protected]>

vs-mobiletools-engineering-service2 · 2025-11-20T08:17:57Z

✅ [PR Build #92caf02] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-20T08:46:55Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T08:26:53Z

✅ [CI Build #92caf02] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:04:45Z

✅ [CI Build #92caf02] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:16:29Z

💻 [CI Build #92caf02] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:19:25Z

💻 [CI Build #92caf02] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:22:09Z

💻 [CI Build #92caf02] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:26:51Z

💻 [CI Build #92caf02] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T09:26:58Z

💻 [CI Build #92caf02] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

vs-mobiletools-engineering-service2 · 2025-11-21T11:00:59Z

🚀 [CI Build #92caf02] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 92caf02aa5efa0d523a0f1d5dfc86b945a3994f9 [PR build]

rolfbjarne added 4 commits November 18, 2025 13:39

[tests] We must set 'UseFloatingTargetPlatformVersion=true' for our t…

889fd58

…est projects, to avoid building them with other workloads than the current workload.

[msbuild] The ComputeRemoteGeneratorProperties task needs to know the…

4f896a3

… value of UseFloatingTargetPlatformVersion. So that it can be passed on when executing `dotnet` to compute binding variables, because otherwise we might end up with variables from the wrong workload.

[tests] Don't set 'UseFloatingTargetPlatformVersion' for the 'BuildMy…

41f907f

…ClassLibrary' test.

[tests] Set 'UseFloatingTargetPlatformVersion' for command-line build…

8222ef4

…s as well.

rolfbjarne requested a review from Copilot November 18, 2025 12:41

Copilot started reviewing on behalf of rolfbjarne November 18, 2025 12:41 View session

Copilot finished reviewing on behalf of rolfbjarne November 18, 2025 12:43

Copilot AI reviewed Nov 18, 2025

View reviewed changes

tests/dotnet/UnitTests/TestBaseClass.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review November 18, 2025 19:10

rolfbjarne requested review from emaf and mauroa as code owners November 18, 2025 19:10

rolfbjarne enabled auto-merge (squash) November 18, 2025 19:11

dalexsoto approved these changes Nov 19, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/tests-floati…

070fcfa

…ng-tpv

This comment has been minimized.

Sign in to view

Update tests/dotnet/UnitTests/TestBaseClass.cs

92caf02

Co-authored-by: Copilot <[email protected]>

This comment has been minimized.

Sign in to view

rolfbjarne disabled auto-merge November 21, 2025 07:52

emaf approved these changes Nov 21, 2025

View reviewed changes

[tests] We must set 'UseFloatingTargetPlatformVersion=true' for our test projects, to avoid building them with other workloads than the current workload. #24281

Are you sure you want to change the base?

[tests] We must set 'UseFloatingTargetPlatformVersion=true' for our test projects, to avoid building them with other workloads than the current workload. #24281

Uh oh!

Conversation

rolfbjarne commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 20, 2025

✅ [PR Build #92caf02] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 20, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

✅ [CI Build #92caf02] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

✅ [CI Build #92caf02] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #92caf02] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #92caf02] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #92caf02] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #92caf02] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

💻 [CI Build #92caf02] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 21, 2025

🚀 [CI Build #92caf02] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants