Add "BuildingInsideVisualStudioCode" option#24776
Open
noiseonwires wants to merge 2 commits intodotnet:mainfrom
Open
Add "BuildingInsideVisualStudioCode" option#24776noiseonwires wants to merge 2 commits intodotnet:mainfrom
noiseonwires wants to merge 2 commits intodotnet:mainfrom
Conversation
Member
|
@noiseonwires can you recreate this PR from origin, and not your fork (and use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a change to improve the Hot Reload experience for .NET MAUI iOS device builds in VS Code:
Accept BuildingInsideVisualStudioCode for .mobile.props import: The VS Code project system sets BuildingInsideVisualStudioCode=true, that should include the .mobile.props file that carries the IDE-selected RuntimeIdentifier so that design-time builds resolve the correct platform assemblies.
In VS Code, design-time builds did not receive the correct RuntimeIdentifier for iOS device targets — they defaulted to iossimulator-x64. This caused Roslyn to resolve the wrong baseline assemblies, that broke Hot Reload. The .mobile.props mechanism (already used by VS on Windows) solves this.