Skip to content

[tests] Render an empty string for function pointers when computing DocIds. #26572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolfbjarne wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −4
Open

[tests] Render an empty string for function pointers when computing DocIds. #26572

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4876058
[tests] Skip FunctionPointerType in Documentation.cs GetDocId.
rolfbjarne Sep 7, 2026
f3a053a
[tests] Update Documentation.KnownFailures.txt after the FunctionPoin…
rolfbjarne Sep 7, 2026
5a93f20
Document handling of function pointers in GetDocId
rolfbjarne Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/cecil-tests/Documentation.KnownFailures.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9735,18 +9735,18 @@ M:CoreFoundation.CFNetwork.ExecuteProxyAutoConfigurationScriptAsync(System.Strin
M:CoreFoundation.CFNetwork.ExecuteProxyAutoConfigurationUrl(System.Uri,System.Uri,Foundation.NSError@)
M:CoreFoundation.CFNetwork.ExecuteProxyAutoConfigurationUrlAsync(System.Uri,System.Uri,System.Threading.CancellationToken)
M:CoreFoundation.CFRange.#ctor(System.IntPtr,System.IntPtr)
M:CoreFoundation.CFReadStream.DoSetClient(.method,System.IntPtr,System.IntPtr)
M:CoreFoundation.CFReadStream.DoSetClient(,System.IntPtr,System.IntPtr)
M:CoreFoundation.CFRunLoop.RunInMode(System.String,System.Double,System.Boolean)
M:CoreFoundation.CFSocket.Invalidate
M:CoreFoundation.CFStream.#ctor(ObjCRuntime.NativeHandle,System.Boolean)
M:CoreFoundation.CFStream.CreateBoundPair(CoreFoundation.CFReadStream@,CoreFoundation.CFWriteStream@,System.IntPtr)
M:CoreFoundation.CFStream.CreateForHTTPRequest(CFNetwork.CFHTTPMessage)
M:CoreFoundation.CFStream.CreateForStreamedHTTPRequest(CFNetwork.CFHTTPMessage,CoreFoundation.CFReadStream)
M:CoreFoundation.CFStream.CreateForStreamedHTTPRequest(CFNetwork.CFHTTPMessage,Foundation.NSInputStream)
M:CoreFoundation.CFStream.DoSetClient(.method,System.IntPtr,System.IntPtr)
M:CoreFoundation.CFStream.DoSetClient(,System.IntPtr,System.IntPtr)
M:CoreFoundation.CFString.op_Implicit(CoreFoundation.CFString)~System.String
M:CoreFoundation.CFString.op_Implicit(System.String)~CoreFoundation.CFString
M:CoreFoundation.CFWriteStream.DoSetClient(.method,System.IntPtr,System.IntPtr)
M:CoreFoundation.CFWriteStream.DoSetClient(,System.IntPtr,System.IntPtr)
M:CoreFoundation.CFWriteStream.Write(System.Byte[],System.IntPtr,System.IntPtr)
M:CoreFoundation.DispatchBlock.op_Explicit(CoreFoundation.DispatchBlock)~System.Action
M:CoreFoundation.DispatchData.CreateMap(System.IntPtr@,System.UIntPtr@)
Expand Down Expand Up @@ -9954,7 +9954,7 @@ M:CoreGraphics.CGPDFObject.TryGetValue(System.IntPtr@)
M:CoreGraphics.CGPDFObject.TryGetValue(System.Runtime.InteropServices.NFloat@)
M:CoreGraphics.CGPDFOperatorTable.Release
M:CoreGraphics.CGPDFOperatorTable.Retain
M:CoreGraphics.CGPDFOperatorTable.SetCallback(System.String,.method)
M:CoreGraphics.CGPDFOperatorTable.SetCallback(System.String,)
M:CoreGraphics.CGPDFPage.Release
M:CoreGraphics.CGPDFPage.Retain
M:CoreGraphics.CGPDFPageInfo.#ctor
Expand Down
3 changes: 3 additions & 0 deletions tests/cecil-tests/Documentation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ static string GetDocId (PropertyDefinition pd)

static string GetDocId (TypeReference tr)
{
if (tr is FunctionPointerType)
return "";
Comment thread
Copilot marked this conversation as resolved.

string name = "";
if (tr.IsNested) {
var decl = tr.DeclaringType;
Expand Down
Loading