Revert Keyboard DeveloperAccessibility PRs#574
Merged
jfversluis merged 2 commits intodotnet:mainfrom Jan 24, 2025
Merged
Conversation
tj-devel709
changed the title
PureWeen
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in this PR: dotnet/maui#27322
These appears to be a bug with CollectionView2 when trying to use these changes in our template. For the time being, we should keep the BindableLayout and make the BindableLayout more accessible for keyboard users.
This PR reverts #573 and #572