Skip to content

[DeveloperBalance] A few changes for Mac Accessibility #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 2 commits into from
Feb 10, 2025
Merged

[DeveloperBalance] A few changes for Mac Accessibility #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b6a2e2
mac changes
tj-devel709 Feb 7, 2025
a98cd51
make the type button
tj-devel709 Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 9.0/Apps/DeveloperBalance/Pages/Controls/CategoryChart.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</Grid>
</shimmer:SfShimmer.CustomView>
<shimmer:SfShimmer.Content>
<chart:SfCircularChart x:Name="Chart">
<chart:SfCircularChart x:Name="Chart" SemanticProperties.Description="Task Categories Chart">
<chart:DoughnutSeries
ItemsSource="{Binding TodoCategoryData}"
PaletteBrushes="{Binding TodoCategoryColors}"
Expand All @@ -30,7 +30,7 @@
ShowDataLabels="True"
EnableTooltip="False"
x:Name="doughnutSeries"
Radius="{OnIdiom 0.7, Phone=0.5}"
Radius="{OnIdiom 0.6, Phone=0.5}"
Copy link
Member Author

@tj-devel709 tj-devel709 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed to fit the graph's labels in certain scenarios

InnerRadius="0.7" >
<chart:DoughnutSeries.LabelTemplate>
<DataTemplate >
Expand Down
1 change: 1 addition & 0 deletions 9.0/Apps/DeveloperBalance/Pages/Controls/ProjectCardView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
xmlns:shimmer="clr-namespace:Syncfusion.Maui.Toolkit.Shimmer;assembly=Syncfusion.Maui.Toolkit"
x:Class="DeveloperBalance.Pages.Controls.ProjectCardView"
Style="{StaticResource CardStyle}"
SemanticProperties.Description="{Binding Name, StringFormat='{0} Project'}"
x:DataType="models:Project">
<shimmer:SfShimmer
BackgroundColor="Transparent"
Expand Down
8 changes: 7 additions & 1 deletion 9.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
<DataTemplate x:DataType="models:IconData">
<Grid RowDefinitions="Auto,4" RowSpacing="{StaticResource size60}"
SemanticProperties.Description="{Binding Description}"
SemanticProperties.Hint="Icon representing the type of task . Tap to select">
SemanticProperties.Hint="Icon representing the type of task . Tap to select"
InputTransparent="True">
<VisualStateManager.VisualStateGroups>
<VisualStateGroup x:Name="CommonStates">
<VisualState x:Name="Normal">
Expand Down Expand Up @@ -127,6 +128,11 @@
HorizontalOptions="Center"
TextColor="{AppThemeBinding Light={StaticResource DarkOnLightBackground},Dark={StaticResource LightOnDarkBackground}}"/>
<BoxView x:Name="SelectedIndicator" Color="{StaticResource Primary}" HeightRequest="4" HorizontalOptions="Fill" Grid.Row="1"/>

<!-- This TapGestureRecognizer ensures that the grid is treated as a button for accessibility purposes on iOS -->
<Grid.GestureRecognizers>
<TapGestureRecognizer />
</Grid.GestureRecognizers>
</Grid>
</DataTemplate>
</CollectionView.ItemTemplate>
Expand Down
2 changes: 1 addition & 1 deletion 9.0/Apps/DeveloperBalance/Pages/ProjectListPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
Spacing="{StaticResource LayoutSpacing}">
<BindableLayout.ItemTemplate>
<DataTemplate x:DataType="models:Project">
<Border>
<Border SemanticProperties.Description="{Binding Name, StringFormat='{0} Project'}">
<VerticalStackLayout Padding="10">
<Label Text="{Binding Name}" FontSize="24" />
<Label Text="{Binding Description}" />
Expand Down
Loading