Migrate EmployeeDirectory and WorkingWithGestures samples#641
Merged
jsuarezruiz merged 11 commits intodotnet:mainfrom Sep 17, 2025
Merged
Migrate EmployeeDirectory and WorkingWithGestures samples#641jsuarezruiz merged 11 commits intodotnet:mainfrom
EmployeeDirectory and WorkingWithGestures samples#641jsuarezruiz merged 11 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
This is an AI migration, manual TODO: Adjust design, refactor, change screenshots |
morning4coffe-dev
changed the title
EmployeeDirectory sampleEmployeeDirectory and WorkingWithGestures samples
jsuarezruiz
suggested changes
Jul 18, 2025
...gWithGestures/DragAndDropGesture/DragAndDropGesture/CustomDataPackageCommandDemoPage.xaml.cs
Outdated
Show resolved
Hide resolved
...gWithGestures/DragAndDropGesture/DragAndDropGesture/CustomDataPackageCommandDemoPage.xaml.cs
Outdated
Show resolved
Hide resolved
10.0/Apps/EmployeeDirectory/Screenshots/Android/Employee List.png
Outdated
Show resolved
Hide resolved
jsuarezruiz
suggested changes
Aug 27, 2025
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
Warning: /Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapInsideImage.cs(42,35): warning CS8622: Nullability of reference types in type of parameter 'sender' of 'void TapInsideImage.OnTapGestureRecognizerTapped(object sender, EventArgs args)' doesn't match the target delegate 'EventHandler<TappedEventArgs>' (possibly because of nullability attributes). [/Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapGesture.csproj::TargetFramework=net9.0-ios]
Warning: /Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapInsideFrame.cs(45,35): warning CS8622: Nullability of reference types in type of parameter 'sender' of 'void TapInsideFrame.OnTapGestureRecognizerTapped(object sender, EventArgs args)' doesn't match the target delegate 'EventHandler<TappedEventArgs>' (possibly because of nullability attributes). [/Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapGesture.csproj::TargetFramework=net9.0-ios]
Warning: /Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapInsideImage.cs(42,35): warning CS8622: Nullability of reference types in type of parameter 'sender' of 'void TapInsideImage.OnTapGestureRecognizerTapped(object sender, EventArgs args)' doesn't match the target delegate 'EventHandler<TappedEventArgs>' (possibly because of nullability attributes). [/Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapGesture.csproj::TargetFramework=net9.0-android]
Warning: /Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapInsideFrame.cs(45,35): warning CS8622: Nullability of reference types in type of parameter 'sender' of 'void TapInsideFrame.OnTapGestureRecognizerTapped(object sender, EventArgs args)' doesn't match the target delegate 'EventHandler<TappedEventArgs>' (possibly because of nullability attributes). [/Users/runner/work/maui-samples/maui-samples/9.0/UserInterface/WorkingWithGestures/TapGesture/TapGesture/TapGesture.csproj::TargetFramework=net9.0-android]
Could update the void TapInsideFrame.OnTapGestureRecognizerTapped(object sender, EventArgs args) sender, to object?.
Contributor
@morning4coffe-dev Could you take a look? |
jsuarezruiz
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #614 and closes #635
Migrates and improves the original EmployeeDirectory and WorkingWithGestures from Xamarin to .NET MAUI.