Skip to content

Fix VoiceOver doesnot announces the State of the ComboBox #32286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+37 −11
Open

Fix VoiceOver doesnot announces the State of the ComboBox #32286

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
835ce5d
fix-30899
SuthiYuvaraj Oct 30, 2025
58eef7e
commit for state
SuthiYuvaraj Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Templates/src/templates/maui-mobile/PageModels/ProjectDetailPageModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ public partial class ProjectDetailPageModel : ObservableObject, IQueryAttributab
[ObservableProperty]
bool _isBusy;

[ObservableProperty]
private bool _isCategoryPickerExpanded;

[ObservableProperty]
private List<IconData> _icons = new List<IconData>
{
Expand Down Expand Up @@ -177,6 +180,18 @@ private async Task TaskCompleted(ProjectTask task)
OnPropertyChanged(nameof(HasCompletedTasks));
}

partial void OnIsCategoryPickerExpandedChanged(bool value)
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space between 'void' and 'OnIsCategoryPickerExpandedChanged'. Should be single space for consistency with the similar method in TaskDetailPageModel.cs.

Copilot uses AI. Check for mistakes.
{
if (value)
{
SemanticScreenReader.Announce("State Expanded");
Copy link
Contributor

@jsuarezruiz jsuarezruiz Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current announcements "State Expanded" and "State Collapsed" lack context about what was expanded/collapsed.

Copy link
Contributor Author

@SuthiYuvaraj SuthiYuvaraj Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz,I’ve updated the SemanticScreenReader with the responsible category. Please review the changes and let me know if you have any feedback or concerns.

Copy link
Contributor

@jsuarezruiz jsuarezruiz Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coded English strings "State Expanded" won't be localized for non-English users. Could include localized resources?

Copy link
Contributor Author

@SuthiYuvaraj SuthiYuvaraj Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz, I checked through the MAUI project templates, and it looks like all existing uses of SemanticProperties and SemanticScreenReader use English text directly, without localisation resources. I’ve followed that same approach here to stay consistent with the current template pattern.

}
else
{
SemanticScreenReader.Announce("State Collapsed");
}
}

[RelayCommand]
private async Task Save()
{
Expand Down
15 changes: 15 additions & 0 deletions src/Templates/src/templates/maui-mobile/PageModels/TaskDetailPageModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ public partial class TaskDetailPageModel : ObservableObject, IQueryAttributable
[ObservableProperty]
private bool _isExistingProject;

[ObservableProperty]
private bool _isProjectPickerExpanded;

public TaskDetailPageModel(ProjectRepository projectRepository, TaskRepository taskRepository, ModalErrorHandler errorHandler)
{
_projectRepository = projectRepository;
Expand Down Expand Up @@ -118,6 +121,18 @@ public bool CanDelete
}
}

partial void OnIsProjectPickerExpandedChanged(bool value)
{
if (value)
{
SemanticScreenReader.Announce("State Expanded");
}
else
{
SemanticScreenReader.Announce("State Collapsed");
}
}

[RelayCommand]
private async Task Save()
{
Expand Down
10 changes: 4 additions & 6 deletions src/Templates/src/templates/maui-mobile/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,13 @@
Text="{Binding Description}" SemanticProperties.Description="Description" />
</sf:SfTextInputLayout>

<sf:SfTextInputLayout
<sf:SfTextInputLayout
Hint="Category"
SemanticProperties.Description="ComboBox to Select Category"
SemanticProperties.Hint="State Collapsed">
<Picker SemanticProperties.Hint="Select the category for the project"
ItemsSource="{Binding Categories}"
SemanticProperties.Description="ComboBox to select a category. Activate to browse and select a category">
<Picker ItemsSource="{Binding Categories}"
SelectedItem="{Binding Category}"
SelectedIndex="{Binding CategoryIndex}"
SemanticProperties.Description="Category State Expanded"/>
IsOpen="{Binding IsCategoryPickerExpanded, Mode=TwoWay}"/>
</sf:SfTextInputLayout>

<Label
Expand Down
8 changes: 3 additions & 5 deletions src/Templates/src/templates/maui-mobile/Pages/TaskDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,16 @@
SemanticProperties.Hint="Indicates if this task is completed" />
</sf:SfTextInputLayout>

<sf:SfTextInputLayout
<sf:SfTextInputLayout
IsVisible="{Binding IsExistingProject}"
SemanticProperties.Description="ComboBox to select Project"
SemanticProperties.Hint="State Collapsed"
SemanticProperties.Description="ComboBox to select a project. Activate to browse and select a project"
Hint="Project">
<Picker
ItemsSource="{Binding Projects}"
ItemDisplayBinding="{Binding Name, x:DataType=models:Project}"
SelectedItem="{Binding Project}"
SelectedIndex="{Binding SelectedProjectIndex}"
SemanticProperties.Description="Project State Expanded"
SemanticProperties.Hint="Which project this task belongs to"/>
IsOpen="{Binding IsProjectPickerExpanded, Mode=TwoWay}"/>
</sf:SfTextInputLayout>

<Button
Expand Down
Loading