[Regression][iOS] Fix MediaPicker PickPhotosAsync getting file name in contentType property #33390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
partner/syncfusion
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the iOS MediaPicker where the FileName was incorrectly being stored in the ContentType property when creating rotated image results. The issue occurred because the FileResult constructor's second parameter expects a MIME type (contentType), but the filename was being passed instead.
Key changes:
- Modified FileResult initialization to use object initializer syntax for setting the FileName property instead of passing it as a constructor parameter
devanathan-vaithiyanathan
changed the title
jfversluis
approved these changes
Jan 8, 2026
Member
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
✅ LGTM - Approved
This is a clean regression fix for the MediaPicker issue where FileName and ContentType were swapped.
Changes:
- Correctly initializes FileResult with proper property assignments
- Preserves both FileName and ContentType as suggested in review
- All CI checks passing (23/23)
Impact:
- Fixes regression introduced in 10.0-preview7
- Restores correct behavior for iOS MediaPicker with RotateImage=true
Great catch and clean fix! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
The FileResult constructor was being called with (filePath, fileName) but the second parameter expects a MIME type, not a filename. This caused the filename to be stored as ContentType.
Description of Change
Fixed FileResult initialization to properly preserve the filename and ContentType.
Regarding Test Case
Picking an image is not possible in a test.
Issues Fixed
Fixes #33348
Tested the behavior in the following platforms.
Before.mov
After.mov