-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Revert PR #31653 : [Testing] Enable UITest Issue18193 on MacCatalyst #33393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR #31653 : [Testing] Enable UITest Issue18193 on MacCatalyst #33393
Conversation
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old image seemed like the correct one based based on other screenshots from the other platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When scaleType = CENTER, adjustViewBounds = true, and Target.SIZE_ORIGINAL are set in native (similar to the MAUI APIs), the native ImageView is rendered in this manner. As a result, we have re-saved the image.
@PureWeen
…33393) This pull request updates UI test cases by reverting Shell navigation test changes that continue to fail in Mac CI. - ShellNavigationShouldWorkInMoreTab test case was previously failing in CI on the Mac platform but was passing locally. Therefore, this PR #31653 was created to resolve the issue. However, the ShellNavigationShouldWorkInMoreTab test still fails in CI on the Mac platform even after the changes. So, the changes from #31653 were reverted.
…33393) This pull request updates UI test cases by reverting Shell navigation test changes that continue to fail in Mac CI. - ShellNavigationShouldWorkInMoreTab test case was previously failing in CI on the Mac platform but was passing locally. Therefore, this PR #31653 was created to resolve the issue. However, the ShellNavigationShouldWorkInMoreTab test still fails in CI on the Mac platform even after the changes. So, the changes from #31653 were reverted.
…33393) This pull request updates UI test cases by reverting Shell navigation test changes that continue to fail in Mac CI. - ShellNavigationShouldWorkInMoreTab test case was previously failing in CI on the Mac platform but was passing locally. Therefore, this PR #31653 was created to resolve the issue. However, the ShellNavigationShouldWorkInMoreTab test still fails in CI on the Mac platform even after the changes. So, the changes from #31653 were reverted.
…33393) This pull request updates UI test cases by reverting Shell navigation test changes that continue to fail in Mac CI. - ShellNavigationShouldWorkInMoreTab test case was previously failing in CI on the Mac platform but was passing locally. Therefore, this PR #31653 was created to resolve the issue. However, the ShellNavigationShouldWorkInMoreTab test still fails in CI on the Mac platform even after the changes. So, the changes from #31653 were reverted.
…alyst (dotnet#33393) This pull request updates UI test cases by reverting Shell navigation test changes that continue to fail in Mac CI. - ShellNavigationShouldWorkInMoreTab test case was previously failing in CI on the Mac platform but was passing locally. Therefore, this PR dotnet#31653 was created to resolve the issue. However, the ShellNavigationShouldWorkInMoreTab test still fails in CI on the Mac platform even after the changes. So, the changes from dotnet#31653 were reverted.
This pull request updates UI test cases by reverting Shell navigation test changes that continue to fail in Mac CI.